Skip to content

Provide SecureHttpTransportParameters to complement SecureTransportParameters counterpart#5432

Merged
cwperks merged 2 commits intoopensearch-project:mainfrom
reta:issue-18559
Jun 24, 2025
Merged

Provide SecureHttpTransportParameters to complement SecureTransportParameters counterpart#5432
cwperks merged 2 commits intoopensearch-project:mainfrom
reta:issue-18559

Conversation

@reta
Copy link
Copy Markdown
Collaborator

@reta reta commented Jun 23, 2025

Description

Implementing the SecureHttpTransportParameters provider APIs, introduced by opensearch-project/OpenSearch#18572

Issues Resolved

Towards opensearch-project/OpenSearch#18559

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rameters counterpart

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta added bug Something isn't working v3.2.0 and removed skip-changelog labels Jun 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (5585a80) to head (65fe82a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../security/ssl/OpenSearchSecureSettingsFactory.java 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5432      +/-   ##
==========================================
- Coverage   72.42%   72.34%   -0.08%     
==========================================
  Files         393      393              
  Lines       24286    24299      +13     
  Branches     3714     3714              
==========================================
- Hits        17590    17580      -10     
- Misses       4868     4891      +23     
  Partials     1828     1828              
Files with missing lines Coverage Δ
.../security/ssl/OpenSearchSecureSettingsFactory.java 48.21% <0.00%> (-14.58%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cwperks
cwperks previously approved these changes Jun 23, 2025
@reta
Copy link
Copy Markdown
Collaborator Author

reta commented Jun 23, 2025

@willyborankin mind please take a look? thanks!

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Copy Markdown
Collaborator Author

reta commented Jun 24, 2025

@cwperks if you have a second to reapprove please, resolved conflicts. Thank you.

@cwperks cwperks merged commit fd83b09 into opensearch-project:main Jun 24, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v3.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants