[BUG] Workload management plugin cannot be upgraded in-situ

[spapadop]

Describe the bug

As per documentation, in order to upgrade a cluster one needs to upgrade the plugins first, so that during the rolling restart the nodes pick up the new upgraded plugin version.

In a cluster that has workload-management plugin installed, the upgrade procedure (i.e., remove and install) does not work, because:

./bin/opensearch-plugin remove workload-management
ERROR: plugin [workload-management] cannot be removed because it is extended by other plugins: [opensearch-security]

Should this safety check be dropped so that the upgrade procedure is unblocked?

As workaround, one can manually move/delete the plugin folder (typically at /usr/share/opensearch/plugins/workload-management).

Related component

Plugins

To Reproduce

1. Bootstrap a cluster on any version
2. Install workload-management plugin (./bin/opensearch-plugin install workload-management)
3. Try to remove it with ./bin/opensearch-plugin remove workload-management

Expected behavior

./bin/opensearch-plugin remove workload-management should be allowed and not blocked by

ERROR: plugin [workload-management] cannot be removed because it is extended by other plugins: [opensearch-security]

Additional Details

Plugins
all bundled ones + workload-management

Host/Environment (please complete the following information):

• OS: AlmaLinux
• Version 9.7

[cwperks]

Since it's an optional extended plugin, I think it would be ok to skip/remove the check.

[cwperks]

@spapadop FYI opened a PR for this: #20417

Workaround would be to remove security, then remove workload-manage, then install workload-management followed by security.

[spapadop]

Thanks a lot @cwperks ! I had tried to remove security but that also gives an error:

ERROR: plugin [opensearch-security] cannot be removed because it is extended by other plugins: [opensearch-anomaly-detection]

I guess that indeed if I follow down that path, in the end I'll remove all plugins in the right order and it'll work 😅