Skip to content

Set a maximum depth for nested queries #3268

@kkhatua

Description

@kkhatua

Is your feature request related to a problem? Please describe.
A recent review of the dependency libraries showed that CVE-2020-36518 (jackson-databind) can lead to creation of a large depth of nested objects and potentially cause a stack overflow.

Describe the solution you'd like
While the immediate fix is upgrading the affected library to a patched version of the library (#2599) we need to constrain this depth in general. This would be the fastest mitigation to protect against other possible vulnerabilities that can be exploited like this through other means, or even by accidental generation through a script.

Describe alternatives you've considered
None. Introduction of a max limit (cluster level setting) would be sufficient to address the issue in general, in context of exploits and in the context of rogue queries generated by accident.

Additional context
None

Metadata

Metadata

Assignees

Labels

Search:ResiliencyenhancementEnhancement or improvement to existing feature or requestgood first issueGood for newcomershacktoberfestGlobal event that encourages people to contribute to open-source.v2.13.0Issues and PRs related to version 2.13.0v3.0.0Issues and PRs related to version 3.0.0

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions