Skip to content

[Backport 2.x] Add threadpool wait time metric (#9681)#10000

Merged
reta merged 1 commit intoopensearch-project:2.xfrom
jed326:backport/backport-9681-to-2.x
Sep 13, 2023
Merged

[Backport 2.x] Add threadpool wait time metric (#9681)#10000
reta merged 1 commit intoopensearch-project:2.xfrom
jed326:backport/backport-9681-to-2.x

Conversation

@jed326
Copy link
Copy Markdown
Contributor

@jed326 jed326 commented Sep 12, 2023

Description

Backport PR for #9681

To be merged at the same time as #10004

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2023

Compatibility status:

Checks if related components are compatible with change 5a30acc

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@jed326 jed326 force-pushed the backport/backport-9681-to-2.x branch from e1c3c31 to 42edfad Compare September 12, 2023 20:10
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@jed326 jed326 force-pushed the backport/backport-9681-to-2.x branch from 42edfad to f16bd34 Compare September 12, 2023 21:43
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Copy Markdown
Contributor Author

jed326 commented Sep 13, 2023

Will take a look at the flakey concurrent search stats test

--

Ah the slice count setting is not dynamic in 2.x. Let me see if I can rework the test then, if not will just add an @ignore for now.

@jed326 jed326 force-pushed the backport/backport-9681-to-2.x branch 2 times, most recently from 87cc5da to ec8fe05 Compare September 13, 2023 03:51
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 force-pushed the backport/backport-9681-to-2.x branch from ec8fe05 to 5a30acc Compare September 13, 2023 04:32
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2023

Codecov Report

Merging #10000 (5a30acc) into 2.x (e4ae8fe) will increase coverage by 0.04%.
Report is 4 commits behind head on 2.x.
The diff coverage is 51.72%.

@@             Coverage Diff              @@
##                2.x   #10000      +/-   ##
============================================
+ Coverage     70.77%   70.81%   +0.04%     
+ Complexity    58209    58205       -4     
============================================
  Files          4810     4810              
  Lines        275125   275150      +25     
  Branches      40433    40439       +6     
============================================
+ Hits         194723   194851     +128     
+ Misses        63814    63656     -158     
- Partials      16588    16643      +55     
Files Changed Coverage Δ
...dination/UnsafeBootstrapClusterManagerCommand.java 0.00% <0.00%> (ø)
...ensearch/rest/action/cat/RestThreadPoolAction.java 11.94% <0.00%> (-0.19%) ⬇️
...ensearch/common/util/concurrent/TimedRunnable.java 63.33% <33.33%> (-3.34%) ⬇️
...ava/org/opensearch/threadpool/ThreadPoolStats.java 77.64% <54.54%> (-3.69%) ⬇️
...ain/java/org/opensearch/threadpool/ThreadPool.java 84.68% <80.00%> (+0.67%) ⬆️
.../util/concurrent/OpenSearchThreadPoolExecutor.java 85.10% <100.00%> (+0.32%) ⬆️
...ent/QueueResizingOpenSearchThreadPoolExecutor.java 58.24% <100.00%> (+1.42%) ⬆️

... and 477 files with indirect coverage changes

@reta reta merged commit 7948353 into opensearch-project:2.x Sep 13, 2023
@jed326 jed326 deleted the backport/backport-9681-to-2.x branch September 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants