Skip to content

[Backport 2.x] fix stale remote cluster uuid state not purged from remote#10403

Merged
sachinpkale merged 1 commit into2.xfrom
backport/backport-10016-to-2.x
Oct 5, 2023
Merged

[Backport 2.x] fix stale remote cluster uuid state not purged from remote#10403
sachinpkale merged 1 commit into2.xfrom
backport/backport-10016-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 5, 2023

Backport 1eec0f1 from #10016.

@github-actions
fix stale remote cluster uuid state not purged from remote (#10016)
9400119 
* fix stale remote cluster uuid state not purged from remote

Signed-off-by: bansvaru <bansvaru@amazon.com>

* fix tests

Signed-off-by: bansvaru <bansvaru@amazon.com>

* use new limit parameter

Signed-off-by: bansvaru <bansvaru@amazon.com>

* minor refactoring

Signed-off-by: bansvaru <bansvaru@amazon.com>

* delete index metadata files before manifest file

Signed-off-by: bansvaru <bansvaru@amazon.com>

* add basic UT

Signed-off-by: bansvaru <bansvaru@amazon.com>

* delete all data related to a cluster uuid in a single call

Signed-off-by: bansvaru <bansvaru@amazon.com>

* fix git diff

Signed-off-by: bansvaru <bansvaru@amazon.com>

* remove unreferenced code

Signed-off-by: bansvaru <bansvaru@amazon.com>

* fix spa

Signed-off-by: bansvaru <bansvaru@amazon.com>

---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit 1eec0f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #10403 (9400119) into 2.x (890663f) will decrease coverage by 0.03%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##                2.x   #10403      +/-   ##
============================================
- Coverage     70.87%   70.84%   -0.03%     
+ Complexity    58477    58455      -22     
============================================
  Files          4829     4829              
  Lines        276310   276327      +17     
  Branches      40573    40573              
============================================
- Hits         195826   195770      -56     
- Misses        63760    63864     +104     
+ Partials      16724    16693      -31
Files Coverage Δ
...arch/gateway/remote/RemoteClusterStateService.java 67.81% <78.26%> (+3.16%) ⬆️

... and 467 files with indirect coverage changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2023

Compatibility status:

Checks if related components are compatible with change 9400119

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@sachinpkale sachinpkale merged commit 16d12e1 into 2.x Oct 5, 2023
@github-actions github-actions bot deleted the backport/backport-10016-to-2.x branch October 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sachinpkale