Skip to content

[Remote Store] Using hash of node id in metadata file names#10480

Merged
gbbafna merged 1 commit intoopensearch-project:mainfrom
gbbafna:nodeId-fix
Oct 7, 2023
Merged

[Remote Store] Using hash of node id in metadata file names#10480
gbbafna merged 1 commit intoopensearch-project:mainfrom
gbbafna:nodeId-fix

Conversation

@gbbafna
Copy link
Copy Markdown
Contributor

@gbbafna gbbafna commented Oct 7, 2023

Description

Using hash of node id in remote segment and translog metadata file names

Related Issues

Resolves #10450

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
@gbbafna gbbafna added backport 2.x Backport to 2.x branch skip-changelog backport 2.11 and removed bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
@gbbafna gbbafna marked this pull request as ready for review October 7, 2023 05:11
@gbbafna gbbafna requested a review from msfroh as a code owner October 7, 2023 05:11
@github-actions github-actions bot added bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2023

Compatibility status:

Checks if related components are compatible with change 9129848

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Copy Markdown
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, do consider adding the suggested changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Copy Markdown
Contributor Author

gbbafna commented Oct 7, 2023

The failing tests are not related to the above changes. These are failing in other gradle runs as well . Since this is a critical fix for Remote Store, I am going to get this one merged.

org.opensearch.script.expression.MoreExpressionIT.testSpecialValueVariable {p0={"search.concurrent_segment_search.enabled":"true"}}
org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException

@gbbafna gbbafna merged commit 98defa5 into opensearch-project:main Oct 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2023
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 98defa5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2023
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 98defa5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
gbbafna added a commit that referenced this pull request Oct 7, 2023
…names (#10491)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna added a commit that referenced this pull request Oct 9, 2023
… names (#10492)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch backport 2.11 bug Something isn't working skip-changelog v2.11.0 Issues and PRs related to version 2.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remote Store] NodeId in segment and translog metadata file name may contain '-'

3 participants