[Remote Store] Using hash of node id in metadata file names#10480
[Remote Store] Using hash of node id in metadata file names#10480gbbafna merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Compatibility status:Checks if related components are compatible with change 9129848 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
ashking94
left a comment
There was a problem hiding this comment.
LGTM overall, do consider adding the suggested changes.
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/remote/RemoteStoreUtilsTests.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferMetadata.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
|
The failing tests are not related to the above changes. These are failing in other gradle runs as well . Since this is a critical fix for Remote Store, I am going to get this one merged. |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 98defa5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 98defa5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch-project#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ch-project#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
…names (#10491) * [Remote Store] Using hash of node id in metadata file names (#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490) Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
… names (#10492) * [Remote Store] Using hash of node id in metadata file names (#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490) Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
…ch-project#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…ch-project#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…ch-project#10480) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Using hash of node id in remote segment and translog metadata file names
Related Issues
Resolves #10450
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.