Enhancing FS stats to include read/write time, queue size and IO time by bharath-techie · Pull Request #10541 · opensearch-project/OpenSearch

bharath-techie · 2023-10-10T18:54:53Z

Description

Adding following fields in fs stats which will be useful in calculating IO stress in a node :

read_time - “Average read time” can be calculated using ( read_time / read_operations )
write_time - “Average write time“ can be calculated using ( write_time / write_operations )
queue_size - Queue size in host
io_time_in_millis - IO utilization percentage

Related Issues

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-10-10T19:11:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27518/
CommitID: eb9ba44
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-10T19:37:13Z

Compatibility status:

Checks if related components are compatible with change 4baa14d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-10-10T19:42:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27520/
CommitID: d251571
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-10T19:44:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27521/
CommitID: 91ba840
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-10T19:44:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27522/
CommitID: ad03870
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-10T19:59:07Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27523/
CommitID: e67811a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-11T05:46:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27573/
CommitID: fe0d55c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-11T07:04:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27580/
CommitID: 3e0107d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-11T08:53:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27584/
CommitID: cd03525
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-11T11:09:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27599/
CommitID: 5f1b33b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

github-actions · 2023-10-11T12:00:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27603/
CommitID: 49a6bcd
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-15T06:57:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27901/
CommitID: 4f62f71
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-15T17:30:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27904/
CommitID: 60f552e
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-16T04:03:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/27906/
CommitID: 60eedcb

codecov · 2023-10-16T04:04:43Z

Codecov Report

Merging #10541 (4baa14d) into main (368d35a) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 70.78%.

@@             Coverage Diff              @@
##               main   #10541      +/-   ##
============================================
- Coverage     71.16%   71.09%   -0.08%     
+ Complexity    58559    58448     -111     
============================================
  Files          4853     4853              
  Lines        275670   275758      +88     
  Branches      40118    40136      +18     
============================================
- Hits         196191   196037     -154     
- Misses        63122    63328     +206     
- Partials      16357    16393      +36

Files	Coverage Δ
...c/main/java/org/opensearch/monitor/fs/FsProbe.java	`82.35% <50.00%> (-2.03%)`	⬇️
...rc/main/java/org/opensearch/monitor/fs/FsInfo.java	`73.17% <71.76%> (-0.60%)`	⬇️

... and 462 files with indirect coverage changes

…ac-pr-fs-stats

github-actions · 2023-10-16T05:53:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/27910/
CommitID: 3d78b03

bharath-techie · 2023-10-16T06:30:49Z

Codecov is reduced due to serialization / deserialization lines which are covered in IT and BWC tests.

github-actions · 2023-10-16T12:05:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27926/
CommitID: 6958224
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-16T13:05:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27930/
CommitID: fecff17
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

…ac-pr-fs-stats

github-actions · 2023-10-16T15:58:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

URL: https://build.ci.opensearch.org/job/gradle-check/27981/
CommitID: 4baa14d
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

opensearch-trigger-bot · 2023-10-18T10:22:16Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10541-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8bc6791f6a3bd58b4ee25bf5ae61504570c8d424
# Push it to GitHub
git push --set-upstream origin backport/backport-10541-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10541-to-2.x.

…opensearch-project#10541) * Enhancing FS stats to include read / write time, io time and queue size Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

…me and queue size (#10696) * Enhancing FS stats to include read/write time, queue size and IO time (#10541) * Enhancing FS stats to include read / write time, io time and queue size Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * 2.x specific changes Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

…opensearch-project#10541) * Enhancing FS stats to include read / write time, io time and queue size Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

…opensearch-project#10541) * Enhancing FS stats to include read / write time, io time and queue size Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

bharath-techie force-pushed the ac-pr-fs-stats branch from eb9ba44 to d251571 Compare October 10, 2023 19:22

bharath-techie force-pushed the ac-pr-fs-stats branch from 91ba840 to ad03870 Compare October 10, 2023 19:38

bharath-techie force-pushed the ac-pr-fs-stats branch from ad03870 to e67811a Compare October 10, 2023 19:42

bharath-techie force-pushed the ac-pr-fs-stats branch from e67811a to fe0d55c Compare October 11, 2023 05:18

bharath-techie force-pushed the ac-pr-fs-stats branch from fe0d55c to 3e0107d Compare October 11, 2023 06:52

bharath-techie force-pushed the ac-pr-fs-stats branch from 3e0107d to cd03525 Compare October 11, 2023 08:19

bharath-techie force-pushed the ac-pr-fs-stats branch from cd03525 to 5f1b33b Compare October 11, 2023 10:39

Enhancing FS stats to include read / write time, io time and queue size

49a6bcd

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

bharath-techie force-pushed the ac-pr-fs-stats branch from 5f1b33b to 49a6bcd Compare October 11, 2023 11:15

bharath-techie marked this pull request as ready for review October 11, 2023 16:36

bharath-techie requested review from Bukhtawar, CEHENKLE, anasalkouz, andrross, dblock, gbbafna, kartg, reta and setiah as code owners October 11, 2023 16:36

bharath-techie force-pushed the ac-pr-fs-stats branch from 4f62f71 to 60f552e Compare October 15, 2023 16:46

bharath-techie force-pushed the ac-pr-fs-stats branch from 60f552e to 60eedcb Compare October 16, 2023 03:21

Merge branch 'main' of github.com:opensearch-project/OpenSearch into …

3d78b03

…ac-pr-fs-stats

bharath-techie force-pushed the ac-pr-fs-stats branch from 60eedcb to 3d78b03 Compare October 16, 2023 05:01

bharath-techie force-pushed the ac-pr-fs-stats branch from 6958224 to fecff17 Compare October 16, 2023 12:25

Merge branch 'main' of github.com:opensearch-project/OpenSearch into …

4baa14d

…ac-pr-fs-stats

bharath-techie force-pushed the ac-pr-fs-stats branch from fecff17 to 4baa14d Compare October 16, 2023 15:18

Bukhtawar merged commit 8bc6791 into opensearch-project:main Oct 17, 2023

bharath-techie added the backport 2.x Backport to 2.x branch label Oct 18, 2023

opensearch-trigger-bot bot added the backport-failed label Oct 18, 2023

bharath-techie mentioned this pull request Oct 18, 2023

[Backport 2.x] Enhancing FS stats to include read / write time, io time and queue size #10696

Merged

7 tasks

ajaymovva mentioned this pull request Oct 26, 2023

[META] Admission Controller Framework #9504

Open

14 tasks

rramachand21 added the v2.12.0 Issues and PRs related to version 2.12.0 label Oct 31, 2023

ajaymovva assigned bharath-techie Nov 2, 2023

BrewTestBot mentioned this pull request Feb 21, 2024

opensearch 2.12.0 Homebrew/homebrew-core#163463

Merged

Conversation

bharath-techie commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 15, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 15, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 16, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 16, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

bharath-techie commented Oct 16, 2023

Uh oh!

github-actions bot commented Oct 16, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 16, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 16, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

opensearch-trigger-bot bot commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

bharath-techie commented Oct 10, 2023 •

edited

Loading

github-actions bot commented Oct 10, 2023 •

edited

Loading

codecov bot commented Oct 16, 2023 •

edited

Loading