Delegating CachingWeightWrapper#count to internal weight object#10543
Delegating CachingWeightWrapper#count to internal weight object#10543andrross merged 8 commits intoopensearch-project:mainfrom
Conversation
…object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 966ae6e Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
|
❌ Gradle check result for 19493a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Needed for #11083 |
|
@niyatiagg -- Can you please add an entry to the CHANGELOG.md file, under the "Unreleased 2.x" section? |
Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10543 +/- ##
============================================
- Coverage 71.27% 71.17% -0.11%
+ Complexity 58932 58836 -96
============================================
Files 4890 4890
Lines 277421 277423 +2
Branches 40308 40308
============================================
- Hits 197723 197445 -278
- Misses 63250 63491 +241
- Partials 16448 16487 +39 ☔ View full report in Codecov by Sentry. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10543-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 72e63f2b3e8257d204bedbc2d04e1aa25adaebf6
# Push it to GitHub
git push --set-upstream origin backport/backport-10543-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> (cherry picked from commit 72e63f2)
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> (cherry picked from commit 72e63f2) Signed-off-by: Ankit Jain <akjain@amazon.com>
…) (#11389) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test * fixing checkstyle violations * fixing existing tests * adding test for delegating count to internal weight object * Fixing failing unit tests * Adding the change log --------- (cherry picked from commit 72e63f2) Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Niyati Aggarwal <121826855+niyatiagg@users.noreply.github.com>
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Delegating from CachingWeightWrapper#count to internal weight object
Related Issues
Resolves #10060
Check List
[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.