[Backport] [2.x] Update bundled JDK to JDK-21.0.1 (#10576) by reta · Pull Request #11003 · opensearch-project/OpenSearch

reta · 2023-10-30T14:08:56Z

Backport of #10576 to 2.x

reta · 2023-10-30T14:10:46Z

@dblock @nknize @andrross switching bundled JDK in 2.x to JDK-21 as we discussed several times (primarily, to address #9423 & Apache Lucene's Panama usage)

github-actions · 2023-10-30T14:18:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29259/
CommitID: 9423fe1
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-30T14:43:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29260/
CommitID: 3d7aa59
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-30T14:45:01Z

Compatibility status:

Checks if related components are compatible with change cef267e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-10-30T17:26:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29273/
CommitID: aadc6eb
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-31T14:26:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

URL: https://build.ci.opensearch.org/job/gradle-check/29375/
CommitID: fa560e8
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-10-31T14:27:03Z

Codecov Report

Merging #11003 (cef267e) into 2.x (822e253) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                2.x   #11003   +/-   ##
=========================================
  Coverage     70.90%   70.90%           
- Complexity    58928    58957   +29     
=========================================
  Files          4862     4862           
  Lines        278394   278401    +7     
  Branches      40810    40812    +2     
=========================================
+ Hits         197396   197408   +12     
- Misses        64189    64280   +91     
+ Partials      16809    16713   -96

Files	Coverage Δ
...a/org/opensearch/gradle/test/DistroTestPlugin.java	`0.00% <ø> (ø)`
.../opensearch/common/util/concurrent/BaseFuture.java	`62.71% <ø> (ø)`
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java	`6.38% <0.00%> (-0.22%)`	⬇️
...g/opensearch/tools/launchers/SystemJvmOptions.java	`0.00% <0.00%> (ø)`

... and 466 files with indirect coverage changes

peternied

@reta I'm going to approve but as there might be downstream impact, please merge when you think it the best time

reta · 2023-11-01T16:50:43Z

@reta I'm going to approve but as there might be downstream impact, please merge when you think it the best time

Thanks a lot @peternied , I am waiting for @nknize @andrross @dblock @CEHENKLE signoff before moving forwards, the impact of this change (going unnoticed) is understood :)

dblock · 2023-11-01T17:30:45Z

I don't know what the implications of this change are.

bbarani · 2023-11-01T17:38:18Z

I don't know what the implications of this change are.

At a high level, this might cause Gradle compatibility issues across multiple repos so we need to start a campaign soon.

reta · 2023-11-01T17:53:17Z

At a high level, this might cause Gradle compatibility issues across multiple repos so we need to start a campaign soon.

Thanks @bbarani, for Gradle specifically - no issues and no changes, this is only runtime change (which is as important as Gradle): we would need to make sure that all plugins work under JDK-21 as a runtime.

I don't know what the implications of this change are.

Thanks @dblock , explained above

dblock

I don't have any strong opinions of when to merge this, your call @reta, PR approved.

IMO downstream plugin pain is not solvable without the kind of decoupling introduced by extensions

reta · 2023-11-10T00:15:38Z

Wouldn't it be better to merge early than later if we are targeting 2.12?

Sure, but this change needs awareness and alignment that it is OK to target 2.12

Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 0d7d1e9) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…rch-project#5279) This switch is removed in JDK version 17. https://openjdk.org/jeps/403 Signed-off-by: Rabi Panda <adnapibar@gmail.com>

…nsearch-project#5205) Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

github-actions · 2023-11-10T14:34:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/29810/
CommitID: cef267e

bbarani · 2023-11-13T21:27:52Z

@dblock @reta @andrross What are the next steps? We will start incorporating the build changes in 2.x line based on the outcome.

reta · 2023-11-13T21:49:04Z

@dblock @reta @andrross What are the next steps? We will start incorporating the build changes in 2.x line based on the outcome.

@bbarani I will plan to merge it tomorrow

reta · 2023-11-14T13:15:07Z

Seeing no objections, merging JDK-21 into 2.x branch

reta added the skip-changelog label Oct 30, 2023

reta force-pushed the backport/backport-10576-to-2.x branch from 9423fe1 to 3d7aa59 Compare October 30, 2023 14:32

peternied approved these changes Oct 31, 2023

View reviewed changes

reta mentioned this pull request Nov 1, 2023

[Backport 2.x] Add Java 11/17/21 matrix for precommit and assemble checks #11045

Merged

peternied approved these changes Nov 1, 2023

View reviewed changes

reta mentioned this pull request Nov 3, 2023

Add Java 11/17/21 matrix for plugin install, test and integration test checks opensearch-project/security#3641

Merged

3 tasks

dblock approved these changes Nov 3, 2023

View reviewed changes

andrross approved these changes Nov 6, 2023

View reviewed changes

heemin32 approved these changes Nov 10, 2023

View reviewed changes

reta and others added 4 commits November 10, 2023 08:46

Update bundled JDK to JDK-21.0.1 (opensearch-project#10576)

3d508c4

Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 0d7d1e9) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Add condition to check JVM version for illegal-access switch (opensea…

492a17e

…rch-project#5279) This switch is removed in JDK version 17. https://openjdk.org/jeps/403 Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Check for JDK version while setting java.security.manager option (ope…

4a56213

…nsearch-project#5205) Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Fix tests and test skaffolding

cef267e

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the backport/backport-10576-to-2.x branch from fa560e8 to cef267e Compare November 10, 2023 13:46

reta requested a review from tlfeng as a code owner November 10, 2023 13:46

reta merged commit b25f5a3 into opensearch-project:2.x Nov 14, 2023

peterzhuamazon mentioned this pull request Nov 27, 2023

Move 2.12.0 to use jdk version 21 opensearch-project/opensearch-build#4239

Merged

zelinh mentioned this pull request Dec 6, 2023

Added neural-search to 2.12 manifest opensearch-project/opensearch-build#4268

Merged

martin-gaievski mentioned this pull request Dec 6, 2023

Added support for jdk-21 opensearch-project/neural-search#500

Merged

3 tasks

reta mentioned this pull request Jan 25, 2024

Add JDK-21 to GA worklflows opensearch-project/sql#2481

Merged

6 tasks

heemin32 mentioned this pull request Mar 19, 2024

[FEATURE] [k-NN] Lucene Engine with SIMD support opensearch-project/k-NN#1062

Closed

Conversation

reta commented Oct 30, 2023

Uh oh!

reta commented Oct 30, 2023

Uh oh!

github-actions bot commented Oct 30, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 30, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Oct 30, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 31, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peternied left a comment

Choose a reason for hiding this comment

Uh oh!

reta commented Nov 1, 2023

Uh oh!

dblock commented Nov 1, 2023

Uh oh!

bbarani commented Nov 1, 2023

Uh oh!

reta commented Nov 1, 2023

Uh oh!

dblock left a comment

Choose a reason for hiding this comment

Uh oh!

reta commented Nov 10, 2023

Uh oh!

github-actions bot commented Nov 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

bbarani commented Nov 13, 2023

Uh oh!

reta commented Nov 13, 2023

Uh oh!

reta commented Nov 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

github-actions bot commented Oct 30, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading