return score with named queries by Dharin-shah · Pull Request #11549 · opensearch-project/OpenSearch

Dharin-shah · 2023-12-09T15:53:57Z

Description

Opensearch already support labelling the queries, that returns as a list in the returned results, of which query it matched. However one of the use case while doing hybrid search with query text and dense vector is to determine individual scores for each query type. This is very useful in further analysis and building offline model to generate better weights for ranking score. Hence adding this feature that sends the client to add the score for each matched query.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-12-09T15:58:14Z

❌ Gradle check result for 4258c61: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-09T16:04:59Z

❌ Gradle check result for bcce0b7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-09T16:15:21Z

Compatibility status:

Checks if related components are compatible with change 3faff83

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2023-12-09T16:33:25Z

❌ Gradle check result for 020503c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-09T17:26:31Z

❕ Gradle check result for 43d2d4e: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-12-09T17:27:02Z

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (332f4c5) 71.32% compared to head (8242e15) 71.40%.

❗ Current head 8242e15 differs from pull request most recent head 3faff83. Consider uploading reports for the commit 3faff83 to get more accurate results

Files	Patch %	Lines
...src/main/java/org/opensearch/search/SearchHit.java	60.00%	13 Missing and 7 partials ⚠️
...rch/search/fetch/subphase/MatchedQueriesPhase.java	0.00%	13 Missing ⚠️
.../opensearch/core/common/io/stream/StreamInput.java	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11549      +/-   ##
============================================
+ Coverage     71.32%   71.40%   +0.07%     
- Complexity    59131    59166      +35     
============================================
  Files          4906     4904       -2     
  Lines        278178   278176       -2     
  Branches      40421    40429       +8     
============================================
+ Hits         198411   198619     +208     
+ Misses        63234    63013     -221     
- Partials      16533    16544      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-09T22:59:24Z

❕ Gradle check result for efaf3e9: UNSTABLE

TEST FAILURES:

      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/20_terms/string profiler via global ordinals}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-12-10T18:17:13Z

❌ Gradle check result for 8d7a91b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-13T17:24:27Z

❌ Gradle check result for 6d88555: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-13T18:18:49Z

❕ Gradle check result for 8242e15: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Dharin-shah · 2023-12-13T18:40:44Z

#9191
Seems to be an open issue for the flaky test @dblock

Signed-off-by: Dharin Shah <Dharin-shah@users.noreply.github.com>

github-actions · 2023-12-17T11:04:01Z

❌ Gradle check result for 53433f9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T11:11:21Z

❌ Gradle check result for 3c1cde4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T11:12:31Z

❌ Gradle check result for a0c1437: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T11:24:56Z

❌ Gradle check result for f973a9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T12:05:25Z

❌ Gradle check result for 612eab3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T12:34:59Z

❌ Gradle check result for bc6dec4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T13:54:20Z

❌ Gradle check result for 30af7a3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

github-actions · 2023-12-17T17:23:17Z

❌ Gradle check result for 882b2d8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-17T17:26:21Z

❌ Gradle check result for 3faff83: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Dharin-shah · 2023-12-17T19:04:35Z

#11626

Replacing by above PR and closing this one due to multiple unsigned commits and rebase issues ^

Dharin-shah marked this pull request as ready for review December 10, 2023 18:27

Dharin-shah requested review from Bukhtawar, CEHENKLE, Rishikesh1159, abbashus, adnapibar, anasalkouz, andrross, dblock, dbwiddis, dreamer-89, gbbafna, kartg, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, peternied, reta, ryanbogan and sachinpkale as code owners December 10, 2023 18:27

Dharin-shah force-pushed the score-for-named-queries branch from 6d88555 to 8242e15 Compare December 13, 2023 17:23

Dharin-shah and others added 3 commits December 17, 2023 11:57

add changelog and api test

53433f9

add changelog

3c1cde4

Merge branch 'main' into score-for-named-queries

a0c1437

Signed-off-by: Dharin Shah <Dharin-shah@users.noreply.github.com>

fix spotless misc check

f973a9b

fix rest api test

612eab3

indent the skip section of rest api spec correctly

bc6dec4

add matched queries with scores test

30af7a3

Dharin-shah added 7 commits December 17, 2023 17:31

signed commit

98ac30b

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

empty commit

882b2d8

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

signed commit

b4e6a58

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

empty commit

1f570b3

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

merge conflict

88a8f4f

signed commit

7148688

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

empty commit

3faff83

Signed-off-by: Dharin Shah <8616130+Dharin-shah@users.noreply.github.com>

Dharin-shah closed this Dec 17, 2023

Dharin-shah deleted the score-for-named-queries branch December 17, 2023 19:04

Conversation

Dharin-shah commented Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

codecov bot commented Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 10, 2023

Uh oh!

github-actions bot commented Dec 13, 2023

Uh oh!

github-actions bot commented Dec 13, 2023

Uh oh!

Dharin-shah commented Dec 13, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

Dharin-shah commented Dec 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dharin-shah commented Dec 9, 2023 •

edited

Loading

github-actions bot commented Dec 9, 2023 •

edited

Loading

codecov bot commented Dec 9, 2023 •

edited

Loading