Skip to content

Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test#11726

Merged
kotwanikunal merged 2 commits intoopensearch-project:mainfrom
dreamer-89:Issue-5031
Jan 3, 2024
Merged

Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test#11726
kotwanikunal merged 2 commits intoopensearch-project:mainfrom
dreamer-89:Issue-5031

Conversation

@dreamer-89
Copy link
Copy Markdown
Member

@dreamer-89 dreamer-89 commented Jan 3, 2024

Description

Test testIndexDeletionDuringSnapshotCreationInQueue creates a async snapshot (wait_for_completion=false) which conflicts during test clean up where repository is deleted. The conflict happens due to in progress snapshot. The fix here is to wait for snapshot to be in completed state.

Related Issues

Resolves #5031

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions github-actions bot added the flaky-test Random test failure that succeeds on second run label Jan 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 3, 2024

Compatibility status:

Checks if related components are compatible with change 2e6c3c6

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 3, 2024

❕ Gradle check result for 2e6c3c6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Jan 3, 2024
@kotwanikunal kotwanikunal merged commit 8440468 into opensearch-project:main Jan 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2024
* Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 8440468)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Jan 3, 2024
#11727)

* Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test



* Update comment



---------


(cherry picked from commit 8440468)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…arch-project#11726)

* Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…arch-project#11726)

* Fix testIndexDeletionDuringSnapshotCreationInQueue flaky test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update comment

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch bug Something isn't working distributed framework flaky-test Random test failure that succeeds on second run skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue flaky

4 participants