Skip to content

[Backport 2.x] Remove ingest processor supports excluding fields (#10967)#11916

Merged
reta merged 1 commit intoopensearch-project:2.xfrom
gaobinlong:backport/backport-10967-to-2.x
Jan 18, 2024
Merged

[Backport 2.x] Remove ingest processor supports excluding fields (#10967)#11916
reta merged 1 commit intoopensearch-project:2.xfrom
gaobinlong:backport/backport-10967-to-2.x

Conversation

@gaobinlong
Copy link
Copy Markdown
Contributor

@gaobinlong gaobinlong commented Jan 18, 2024

Description

Backport #10967 to 2.x.

Related Issues

#1578

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…#10967)

* Remove ingest processor supports field patterns and excluding fields

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Format some code

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Remove the code of field pattern

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Add skip version in rest test yml

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Make fields and exclude_fields mutually exclusive when constructing RemoveProcessor

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit 5dd4b61)
@gaobinlong
Copy link
Copy Markdown
Contributor Author

Hi @reta ,please help to review this backport PR, thanks!

@github-actions
Copy link
Copy Markdown
Contributor

Compatibility status:

Checks if related components are compatible with change 175a413

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git]

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 175a413: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromLocalNode
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c48fb55) 71.04% compared to head (175a413) 71.10%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/ingest/common/RemoveProcessor.java 88.88% 3 Missing and 5 partials ⚠️
...va/org/opensearch/ingest/common/CopyProcessor.java 93.61% 3 Missing ⚠️
...g/opensearch/ingest/common/IngestCommonPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11916      +/-   ##
============================================
+ Coverage     71.04%   71.10%   +0.05%     
- Complexity    59352    59407      +55     
============================================
  Files          4890     4891       +1     
  Lines        279826   279915      +89     
  Branches      41035    41050      +15     
============================================
+ Hits         198799   199030     +231     
+ Misses        64210    64071     -139     
+ Partials      16817    16814       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 18, 2024
@reta reta merged commit 62493f4 into opensearch-project:2.x Jan 18, 2024
@gaobinlong gaobinlong deleted the backport/backport-10967-to-2.x branch June 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2.12.0 Issues and PRs related to version 2.12.0

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants