Skip to content

[Backport 2.x] Support index level allocation filtering for searchable snapshot index#11927

Merged
kotwanikunal merged 1 commit into2.xfrom
backport/backport-11563-to-2.x
Jan 24, 2024
Merged

[Backport 2.x] Support index level allocation filtering for searchable snapshot index#11927
kotwanikunal merged 1 commit into2.xfrom
backport/backport-11563-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jan 18, 2024

Backport 2f81c57 from #11563.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 18, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change b939844

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 18, 2024

❕ Gradle check result for 624508f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (b72f1d1) 71.12% compared to head (b939844) 71.10%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...ing/allocation/allocator/RemoteShardsBalancer.java 45.61% 19 Missing and 12 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11927      +/-   ##
============================================
- Coverage     71.12%   71.10%   -0.03%     
- Complexity    59384    59416      +32     
============================================
  Files          4891     4891              
  Lines        279944   279955      +11     
  Branches      41055    41065      +10     
============================================
- Hits         199113   199053      -60     
- Misses        63904    64039     +135     
+ Partials      16927    16863      -64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal force-pushed the backport/backport-11563-to-2.x branch from 624508f to 2d46cbb Compare January 22, 2024 21:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2024

❌ Gradle check result for 2d46cbb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2024

❌ Gradle check result for 2d46cbb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions @kotwanikunal
Support index level allocation filtering for searchable snapshot index (
b939844 
#11563)

* support index level allocation filtering

Signed-off-by: panguixin <panguixin@bytedance.com>

* run spotless

Signed-off-by: panguixin <panguixin@bytedance.com>

* fix IT

Signed-off-by: panguixin <panguixin@bytedance.com>

* fix not statement and add change log

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
(cherry picked from commit 2f81c57)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal kotwanikunal force-pushed the backport/backport-11563-to-2.x branch from 2d46cbb to b939844 Compare January 24, 2024 18:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 24, 2024

❕ Gradle check result for b939844: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kotwanikunal kotwanikunal merged commit ed80008 into 2.x Jan 24, 2024
@github-actions github-actions bot deleted the backport/backport-11563-to-2.x branch January 24, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

+1 more reviewer

@deshsidd deshsidd deshsidd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deshsidd @kotwanikunal