[Backport 2.x] Fix from and size parameter can be negative when searching (#13047)

[gaobinlong]

Description

Backport #13047 to 2.x.

Related Issues

#11290

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 4c0e38a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 772d6dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 2209280: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gaobinlong]

❌ Gradle check result for 2209280: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

No test failures found, hi @dblock , could you help to review this PR, thank you!

[dblock]

❌ Gradle check result for 2209280: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

No test failures found, hi @dblock , could you help to review this PR, thank you!

> Task :distribution:bwc:maintenance:buildBwcLinuxTar FAILED

This needs a rebase.

[dblock]

Looks good. The bcw test failure needs a rebase, please? I know it's annoying, but those can be real bugs, so we don't want to get in the habit of merging things without a passing build even if we 100% believe this is a flake or something already fixed.

[github-actions]

❌ Gradle check result for ca4a90f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gaobinlong]

❌ Gradle check result for ca4a90f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

There's an issue tracking the failed test in CacheStatsHolderTests, for another 2 failed tests in AzureBlobStoreRepositoryTests which show timeout error, seems caused by one node in the cluster goes down so the api call has no response.

[github-actions]

❕ Gradle check result for b9a8ce5: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.09%. Comparing base (0dd892c) to head (b9a8ce5).
Report is 180 commits behind head on 2.x.

Files	Patch %	Lines
...pensearch/rest/action/search/RestSearchAction.java	25.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x   #13361      +/-   ##
============================================
- Coverage     71.28%   71.09%   -0.19%     
- Complexity    60145    60687     +542     
============================================
  Files          4957     5011      +54     
  Lines        282799   285873    +3074     
  Branches      41409    41781     +372     
============================================
+ Hits         201591   203255    +1664     
- Misses        64189    65525    +1336     
- Partials      17019    17093      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.