Allow clearing remote_store.compatibility_mode setting#13646
Merged
gbbafna merged 1 commit intoopensearch-project:mainfrom May 14, 2024
Merged
Allow clearing remote_store.compatibility_mode setting#13646gbbafna merged 1 commit intoopensearch-project:mainfrom
remote_store.compatibility_mode setting#13646gbbafna merged 1 commit intoopensearch-project:mainfrom
Conversation
github-actions
bot
added
bug
BhumikaSaini-Amazon
force-pushed
the
compatibility-mode
branch
from
0242f66 to
773b224
Compare
Contributor
|
❌ Gradle check result for 0242f66: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...nalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationSettingsUpdateIT.java
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for 773b224: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
BhumikaSaini-Amazon
force-pushed
the
compatibility-mode
branch
from
773b224 to
29a9695
Compare
BhumikaSaini-Amazon
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale and
saratvemulapalli
as code owners
BhumikaSaini-Amazon
requested review from
VachaShah,
shwetathareja,
sohami and
tlfeng
as code owners
BhumikaSaini-Amazon
requested review from
gbbafna
and removed request for
gbbafna
gbbafna
approved these changes
May 14, 2024
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13646 +/- ##
============================================
+ Coverage 71.42% 71.67% +0.25%
- Complexity 59978 61184 +1206
============================================
Files 4985 5058 +73
Lines 282275 287456 +5181
Branches 40946 41641 +695
============================================
+ Hits 201603 206035 +4432
- Misses 63999 64400 +401
- Partials 16673 17021 +348 ☔ View full report in Codecov by Sentry. |
ltaragi
approved these changes
May 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 14, 2024
Signed-off-by: Bhumika Saini <sabhumik@amazon.com> (cherry picked from commit f8baa4a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
May 17, 2024
…oject#13646) Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
BhumikaSaini-Amazon
pushed a commit
to BhumikaSaini-Amazon/OpenSearch
that referenced
this pull request
May 21, 2024
…oject#13646) Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
9 tasks
gbbafna
pushed a commit
that referenced
this pull request
May 21, 2024
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…oject#13646) Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow clearing
remote_store.compatibility_modesettingRelated Issues
Resolves #13634
Check List
New functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.