Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode

[imRishN]

Description

Skip unnecessary string format in ThrottlingAllocationDecider when not in debug mode

Related Issues

Resolves #13743

Check List

• [ ] New functionality includes testing.
  • [ ] All tests pass
• [ ] New functionality has been documented.
  • [ ] New functionality has javadoc added
• [ ] API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 7239ec7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for de2f3a1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[Bukhtawar]

Test Result (8 failures / +8)
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"true"}}
org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}}
org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"false"}}
org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}}

[Bukhtawar]

LGTM, can we add a test to validate of the debug decision message is consistent with the status quo. Please point me to an existing one if they exist

[github-actions]

✅ Gradle check result for de2f3a1: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (b15cb0c) to head (de2f3a1).
Report is 294 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13750      +/-   ##
============================================
+ Coverage     71.42%   71.52%   +0.10%     
- Complexity    59978    61233    +1255     
============================================
  Files          4985     5061      +76     
  Lines        282275   287871    +5596     
  Branches      40946    41692     +746     
============================================
+ Hits         201603   205895    +4292     
- Misses        63999    64969     +970     
- Partials      16673    17007     +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[imRishN]

LGTM, can we add a test to validate of the debug decision message is consistent with the status quo. Please point me to an existing one if they exist

OpenSearch/server/src/test/java/org/opensearch/cluster/routing/allocation/ThrottlingAllocationTests.java

Line 276 in 3fe6674

public void testOutgoingThrottlesAllocationOldIndex() {

- this test asserts the decision explanation. This should suffice?

[Bukhtawar]

Flaky test #12197