Skip to content

[Backport 2.x] Adds latency metrics for ClusterState Appliers and Listeners#13755

Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into2.xfrom
backport/backport-12333-to-2.x
Closed

[Backport 2.x] Adds latency metrics for ClusterState Appliers and Listeners#13755
opensearch-trigger-bot[bot] wants to merge 1 commit into2.xfrom
backport/backport-12333-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented May 20, 2024

Backport a254aa9 from #12333.

@github-actions
Adds latency metrics for ClusterState Appliers and Listeners (#12333)
6d23c1d 
* Adds latency metrics for ClusterState Appliers and Listeners

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
(cherry picked from commit a254aa9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2024

❕ Gradle check result for 6d23c1d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2
Copy link
Copy Markdown
Member

mch2 commented May 20, 2024

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@shwetathareja
Copy link
Copy Markdown
Member

shwetathareja commented May 27, 2024

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@mch2 ClusterService, MasterService, AllocationService, for all these classes singleton objects are created in Node.java and then injected all throughout. How do you suggest we can handle constructor changes here?

This was referenced Jun 3, 2024
Merged
Closed
@gargharsh3134 gargharsh3134 mentioned this pull request Jun 10, 2024
Merged
3 tasks
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor Author

opensearch-trigger-bot bot commented Jun 26, 2024

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 26, 2024
@mch2
Copy link
Copy Markdown
Member

mch2 commented Jun 26, 2024 •
edited
Loading

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@mch2 ClusterService, MasterService, AllocationService, for all these classes singleton objects are created in Node.java and then injected all throughout. How do you suggest we can handle constructor changes here?

apologies @shwetathareja for the late reply - seems this has been resolved with overloading the ctors in #13926. I think we can merge this backport with a rebase?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jun 27, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 27, 2024
Open
@gargharsh3134
Copy link
Copy Markdown
Contributor

gargharsh3134 commented Jul 4, 2024

Another backport PR was merged to address this (#14118).
This PR is no longer required and can be closed.

@dbwiddis dbwiddis deleted the backport/backport-12333-to-2.x branch July 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mch2 @shwetathareja @gargharsh3134