[Backport 2.x] Gradle Check Optimization

[opensearch-trigger-bot]

Backport 5441d55 from #13786.

[github-actions]

❌ Gradle check result for cddb3cf: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for cddb3cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for cddb3cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for cddb3cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[prudhvigodithi]

The gradle check failure here is expected as the new field post_merge_action is not present (inferred as null {"post_merge_action":"") in 2.x branch until this PR is merged, here is the failure link https://build.ci.opensearch.org/job/gradle-check/39103/console. We should force merge this.
Thanks to @peterzhuamazon for confirming this.

[peterzhuamazon]

The gradle check failure here is expected as the new field post_merge_action is not present (inferred as null {"post_merge_action":"") in 2.x branch until this PR is merged, here is the failure link https://build.ci.opensearch.org/job/gradle-check/39103/console. We should force merge this. Thanks to @peterzhuamazon for confirming this.

Second to this, as the code is using pull_request_target event so all the workflow files changes are coming from the current merged 2.x branch head commit, not from fork.

Thanks.

[prudhvigodithi]

@peternied can we go ahead and merge this?

[prudhvigodithi]

Adding @andrross @dblock as well to please take a look.

[jed326]

Think we need someone from @opensearch-project/admin to help merge as maintainers are not able to override checks anymore.

[prudhvigodithi]

Thanks @jed326 I will take care of it.

[peternied]

@prudhvigodithi @jed326 - It looks like the gradle check wasn't handling the case where the data was missing gracefully. This seems like a miss in the jenkins library change.

Most importantly - Is merging code unblocked in other pull requests targeting 2.x / 1.x branches? Do they need to rebase/merge from main?

For follow up can we update the jenkins library to catch and handle these issues better?

groovy.lang.MissingPropertyException: No such property: post_merge_action for class: groovy.lang.Binding
	at groovy.lang.Binding.getVariable(Binding.java:63)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:285)
	at org.kohsuke.groovy.sandbox.impl.Checker$7.call(Checker.java:375)

[prudhvigodithi]

Hey @peternied, yes open PR's still needs to rebased. The ideal way was to 1st merge all the gradle change backport PR's from core repo and then the Jenkinsfile change (PR: opensearch-project/opensearch-build#4719) that handles the new fields, then it would not throw the error as No such property: post_merge_action as the jenkins build would continue to builds with just the old fields. Now the jenkins change was merged before the backports hence ended up in this error. Once the backports are merged we should not see this error as moving forward the post_merge_action field is mandatory (either true/false) in all runs.
@peterzhuamazon

[peternied]

@prudhvigodithi Could you comment on all opens PRs that need to rebase so those authors know how to get the check to pass again / avoid troubleshooting that failure?

[prudhvigodithi]

Sure, before that let me see if using pull_request_target: there is a better way to always get the latest workflow file from the source repo branch, if we have a way like this then simple re-run of the gradle check on the open PR should solve the problem, no need to rebase.

[opensearch-trigger-bot]

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/backport-2.14
# Create a new branch
git switch --create backport/backport-13787-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c13cbec0f553d47e24739806f010095481fea5
# Push it to GitHub
git push --set-upstream origin backport/backport-13787-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-13787-to-2.14.

[opensearch-trigger-bot]

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/backport-2.14
# Create a new branch
git switch --create backport/backport-13787-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c13cbec0f553d47e24739806f010095481fea5
# Push it to GitHub
git push --set-upstream origin backport/backport-13787-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-13787-to-2.14.

[opensearch-trigger-bot]

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/backport-2.14
# Create a new branch
git switch --create backport/backport-13787-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c13cbec0f553d47e24739806f010095481fea5
# Push it to GitHub
git push --set-upstream origin backport/backport-13787-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-13787-to-2.14.