Skip to content

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests#1390

Merged
dblock merged 1 commit intoopensearch-project:mainfrom
reta:fix.flaky.tests
Oct 20, 2021
Merged

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests#1390
dblock merged 1 commit intoopensearch-project:mainfrom
reta:fix.flaky.tests

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Oct 19, 2021

Description

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests

Issues Resolved

Closes #1389 and #1388

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   DCO Check Passed d7d571438102f6178c1d59824d498f94f4ef8909

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning with netty 4.1.69.Final

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Wrapper Validation success d7d571438102f6178c1d59824d498f94f4ef8909

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CI node gets really busy, 1s may not be enough (this is total operation timeout, not network one)

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

❌   Gradle Precommit failure d7d571438102f6178c1d59824d498f94f4ef8909
Log 1351

…ts and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Wrapper Validation success d6b9bbc

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   DCO Check Passed d6b9bbc

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Precommit success d6b9bbc

@dblock
Copy link
Copy Markdown
Member

dblock commented Oct 19, 2021

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

❌   Gradle Check failure d6b9bbc
Log 736

Reports 736

@reta
Copy link
Copy Markdown
Contributor Author

reta commented Oct 20, 2021

❌ Gradle Check failure d6b9bbc Log 736

Reports 736

@dblock another flaky one? First time I see it, have you seen it before?

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SharedClusterSnapshotRestoreIT.testSnapshotCanceledOnRemovedShard" -Dtests.seed=9350EB7A8335C1F9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=sl -Dtests.timezone=SystemV/PST8 -Druntime.java=17

org.opensearch.snapshots.SharedClusterSnapshotRestoreIT > testSnapshotCanceledOnRemovedShard FAILED
    SnapshotMissingException[[test-repo:test-snap] is missing]
        at org.opensearch.action.admin.cluster.snapshots.get.TransportGetSnapshotsAction.masterOperation(TransportGetSnapshotsAction.java:160)
        at org.opensearch.action.admin.cluster.snapshots.get.TransportGetSnapshotsAction.masterOperation(TransportGetSnapshotsAction.java:80)
        at org.opensearch.action.support.master.TransportMasterNodeAction.masterOperation(TransportMasterNodeAction.java:124)
        at org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction.lambda$doStart$3(TransportMasterNodeAction.java:197)
        at org.opensearch.action.ActionRunnable$2.doRun(ActionRunnable.java:86)
        at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:792)
        at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:50)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.lang.Thread.run(Thread.java:833)

@nknize
Copy link
Copy Markdown
Contributor

nknize commented Oct 20, 2021

another flaky one? First time I see it...

I've seen this failure before. It's sporadic and needs deeper investigation so I opened #1396

Rerunning gradle check here...

@nknize
Copy link
Copy Markdown
Contributor

nknize commented Oct 20, 2021

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success d6b9bbc
Log 747

Reports 747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix org.opensearch.action.admin.cluster.node.stats.NodeStatsTests.testSerialization (flaky)

4 participants