Add DCO workflow until dcoapp/app issue is fixed#13970
Merged
prudhvigodithi merged 1 commit intoopensearch-project:mainfrom Jun 4, 2024
Merged
Add DCO workflow until dcoapp/app issue is fixed#13970prudhvigodithi merged 1 commit intoopensearch-project:mainfrom
prudhvigodithi merged 1 commit intoopensearch-project:mainfrom
Conversation
github-actions
bot
added
>FORK
prudhvigodithi
changed the title
prudhvigodithi
added
backport 1.x
backport 2.x
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
github-actions
bot
added
>FORK
peternied
approved these changes
Jun 4, 2024
Member
|
@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think? |
Contributor
@andrross I think workflow is an acceptable alternative to keep (instead of app that proves to be unstable) for good. |
reta
approved these changes
Jun 4, 2024
Member
Luckily we've already got this workflow, I would rather have machines read every commit and return a ✅ or ❌ on each PR than train myself to do this repetitive task. |
Contributor
|
@prudhvigodithi we are all set, but needs forced merge |
Member
Author
|
Let me force merge this PR and once the backports are done I will update the branch rule to point to this new DCO workflow. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
that referenced
this pull request
Jun 4, 2024
prudhvigodithi
pushed a commit
that referenced
this pull request
Jun 4, 2024
prudhvigodithi
pushed a commit
that referenced
this pull request
Jun 4, 2024
prudhvigodithi
pushed a commit
that referenced
this pull request
Jun 4, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
gaobinlong
pushed a commit
to gaobinlong/OpenSearch
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
LantaoJin
pushed a commit
to LantaoJin/OpenSearch
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like the DCO app issue may take some time to get fully fixed dcoapp/app#211 (comment), for temporary fix we can use https://github.com/tim-actions/dco to run the DCO checks. We have used this in past for job-scheduler repo https://github.com/opensearch-project/job-scheduler/tree/1.3.16.0/.github/workflows, this should unblock the open PR's with mandatory DCO branch rule.
Related Issues
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.