Optimize remote state stale file deletion#13995
Merged
sachinpkale merged 3 commits intoopensearch-project:mainfrom Jun 6, 2024
Merged
Optimize remote state stale file deletion#13995sachinpkale merged 3 commits intoopensearch-project:mainfrom
sachinpkale merged 3 commits intoopensearch-project:mainfrom
Conversation
sachinpkale
reviewed
Jun 5, 2024
server/src/main/java/org/opensearch/common/util/concurrent/AbstractAsyncTask.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for fc429fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Contributor
|
❌ Gradle check result for f932b54: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Contributor
sachinpkale
approved these changes
Jun 6, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13995-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3de5d3c273e744a76459c88f3a6341ed3173f5a0
# Push it to GitHub
git push --set-upstream origin backport/backport-13995-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
LantaoJin
pushed a commit
to LantaoJin/OpenSearch
that referenced
this pull request
Jun 6, 2024
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
3 tasks
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Jun 8, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jun 8, 2024
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This was referenced Jun 13, 2024
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#14025) (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding b9befaa added in #13131 back, we are now using dedicated threadpool
remote_purgefor deletion of stale files.Ran the test for 1000 times locally to check for flakiness
Related Issues
Resolves #12889
Resolves #12798 that test case is getting removed in this PR
Resolves #13968
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.