[Remote Store] Add checks to skip remote uploads after shard is closed

[shourya035]

Description

Adding checks in RemoteStoreRefreshListener to return false for shouldSync if the underlying indexShard instance has transitioned to a CLOSED state. This would prevent the shouldRetry method to schedule refresh retries even after the IndexShard instance and it's corresponding Remote directories are closed.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

#13996

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 6358f71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 6358f71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 6358f71: SUCCESS

[github-actions]

❌ Gradle check result for ebdc32c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shourya035]

org.opensearch.cache.common.tier.TieredSpilloverCacheStatsIT.testTierLevelAggregation

Reopened: #6124

org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

Opened: #14029

[github-actions]

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shourya035]

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode

#13600

org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithMultipleIndices {p0={"search.concurrent_segment_search.enabled":"false"}}

#13437

[github-actions]

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for bf2e0e9: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.58%. Comparing base (b15cb0c) to head (bf2e0e9).
Report is 353 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13998      +/-   ##
============================================
+ Coverage     71.42%   71.58%   +0.16%     
- Complexity    59978    61316    +1338     
============================================
  Files          4985     5065      +80     
  Lines        282275   288201    +5926     
  Branches      40946    41741     +795     
============================================
+ Hits         201603   206309    +4706     
- Misses        63999    64852     +853     
- Partials      16673    17040     +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.