Skip to content

Revert "COMPAT locale provider will be removed in a future release (#13988)"#14039

Merged
reta merged 1 commit intoopensearch-project:mainfrom
reta:revert.13988
Jun 6, 2024
Merged

Revert "COMPAT locale provider will be removed in a future release (#13988)"#14039
reta merged 1 commit intoopensearch-project:mainfrom
reta:revert.13988

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Jun 6, 2024

This reverts commit ba0df74.

Description

Reverting #13988 due to new flaky tests:

org.opensearch.common.joda.JavaJodaTimeDuellingTests.testIncompatiblePatterns


java.lang.AssertionError: 
Expected: "2019-01-01T01:01:01.001UTC"
     but: was "2019-01-01T01:01:01.001م ع و"
	at __randomizedtesting.SeedInfo.seed([D64AD5330C8A32D4:38C13EFEC3AE978C]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.junit.Assert.assertThat(Assert.java:964)
	at org.junit.Assert.assertThat(Assert.java:930)
	at org.opensearch.common.joda.JavaJodaTimeDuellingTests.testIncompatiblePatterns(JavaJodaTimeDuellingTests.java:189)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:1583)

./gradlew ':server:test' --tests "org.opensearch.common.joda.JavaJodaTimeDuellingTests.testIncompatiblePatterns" -Dtests.seed=D64AD5330C8A32D4

./gradlew ':server:test' --tests "org.opensearch.common.joda.JavaJodaTimeDuellingTests.testIncompatiblePatterns" -Dtests.seed=5593D79ECB158B24

Related Issues

Unresolves #11550

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#13988)"

This reverts commit ba0df74.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Copy Markdown
Contributor Author

reta commented Jun 6, 2024

@akolarkunnu fyi, I am reverting #13988 since there are new flaky tests surfacing (reproduction steps added)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for c982f14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Copy Markdown
Contributor Author

reta commented Jun 6, 2024

❌ Gradle check result for c982f14: FAILURE

#13046

@reta reta mentioned this pull request Jun 6, 2024
3 tasks
@reta
Copy link
Copy Markdown
Contributor Author

reta commented Jun 6, 2024

@andrross @dblock could you please take a look folks? thank you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for c982f14: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (b15cb0c) to head (c982f14).
Report is 358 commits behind head on main.

Files Patch % Lines
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java 0.00% 1 Missing ⚠️
...g/opensearch/tools/launchers/SystemJvmOptions.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14039      +/-   ##
============================================
+ Coverage     71.42%   71.55%   +0.13%     
- Complexity    59978    61361    +1383     
============================================
  Files          4985     5073      +88     
  Lines        282275   288525    +6250     
  Branches      40946    41776     +830     
============================================
+ Hits         201603   206468    +4865     
- Misses        63999    64980     +981     
- Partials      16673    17077     +404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit ecf3c3d into opensearch-project:main Jun 6, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants