Skip to content

[Backport-13994] Adds support to provide tags with value in Gauge metric#14138

Merged
reta merged 1 commit intoopensearch-project:2.xfrom
Gaganjuneja:bp-13994-to-2.x
Jun 10, 2024
Merged

[Backport-13994] Adds support to provide tags with value in Gauge metric#14138
reta merged 1 commit intoopensearch-project:2.xfrom
Gaganjuneja:bp-13994-to-2.x

Conversation

@Gaganjuneja
Copy link
Copy Markdown
Contributor

Description

backport of #13994

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…roject#13994)

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds build issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
@Gaganjuneja
Copy link
Copy Markdown
Contributor Author

@reta, please take a look. Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 6377352: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (0dd892c) to head (6377352).
Report is 333 commits behind head on 2.x.

Files Patch % Lines
...pensearch/telemetry/metrics/TaggedMeasurement.java 0.00% 7 Missing ⚠️
...ch/telemetry/metrics/noop/NoopMetricsRegistry.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14138      +/-   ##
============================================
+ Coverage     71.28%   71.45%   +0.16%     
- Complexity    60145    61717    +1572     
============================================
  Files          4957     5062     +105     
  Lines        282799   289639    +6840     
  Branches      41409    42264     +855     
============================================
+ Hits         201591   206955    +5364     
- Misses        64189    65233    +1044     
- Partials      17019    17451     +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit fa7a88a into opensearch-project:2.x Jun 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…roject#13994) (opensearch-project#14138)

* Adds support to provide tags with value in Gauge metric

* Adds support to provide tags with value in Gauge metric

* Adds support to provide tags with value in Gauge metric

* Adds build issue

* Fix compilation issue

* Empty-Commit

* Empty-Commit

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants