Skip to content

limit the max value of cluster.max_shards_per_node to avoid int overflow #14155

Merged
shwetathareja merged 2 commits into
opensearch-project:mainfrom
kkewwei:pr_13907
Jun 20, 2024
Merged

limit the max value of cluster.max_shards_per_node to avoid int overflow #14155
shwetathareja merged 2 commits into
opensearch-project:mainfrom
kkewwei:pr_13907

Conversation

@kkewwei
Copy link
Copy Markdown
Contributor

@kkewwei kkewwei commented Jun 11, 2024 •
edited
Loading

Signed-off-by: kkewwei kkewwei@163.com

Description

Limit the max value of cluster.max_shards_per_node to avoid int overflow. We can't reach 1_500_000 in the current opensearch struct.

Related Issues

Resolves #13907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions Bot added bug Something isn't working Cluster Manager labels Jun 11, 2024
@kkewwei kkewwei force-pushed the pr_13907 branch 2 times, most recently from f73f384 to 730b329 Compare June 11, 2024 01:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2024

❌ Gradle check result for f73f384: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2024

❌ Gradle check result for 730b329: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2024

❌ Gradle check result for 3616d55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2024

✅ Gradle check result for b49cd2e: SUCCESS

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 12, 2024

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 12, 2024

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ReindexBasicTests.testMultipleSources #13913

shwetathareja
shwetathareja reviewed Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@shwetathareja shwetathareja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkewwei , minor comment otherwise looks good.

Comment thread server/src/main/java/org/opensearch/indices/ShardLimitValidator.java
This was referenced Jun 13, 2024
Closed
Open
Closed
Closed
Open
Open
@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 17, 2024

@shwetathareja please see again.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 18, 2024

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Copy Markdown
Member

shwetathareja commented Jun 20, 2024

@kkewwei please fix the conflict in ChangeLog.md

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2024

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Merge branch 'main' into pr_13907
bda874c 
Signed-off-by: kkewwei <kkewwei@163.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2024

✅ Gradle check result for bda874c: SUCCESS

@shwetathareja shwetathareja merged commit 761e207 into opensearch-project:main Jun 20, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jun 20, 2024
@github-actions
Fix the computed max shards of cluster to avoid int overflow (#14155)
0971e61 
Signed-off-by: kkewwei <kkewwei@163.com>
(cherry picked from commit 761e207)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Jun 20, 2024
Merged
dblock pushed a commit that referenced this pull request Jun 20, 2024
@opensearch-trigger-bot @github-actions
Fix the computed max shards of cluster to avoid int overflow (#14155) (…
29ac578 
…#14474)

(cherry picked from commit 761e207)

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kkewwei kkewwei deleted the pr_13907 branch June 21, 2024 03:07
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@kkewwei @harshavamsi
Fix the computed max shards of cluster to avoid int overflow (opensea…
ad95677 
…rch-project#14155)

Signed-off-by: kkewwei <kkewwei@163.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Fix the computed max shards of cluster to avoid int overflow (opensea…
cd323b0 
…rch-project#14155) (opensearch-project#14474)

(cherry picked from commit 761e207)

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@kkewwei
Fix the computed max shards of cluster to avoid int overflow (opensea…
a50acc3 
…rch-project#14155)

Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 1, 2024
Open
@tkykenmt tkykenmt mentioned this pull request Jan 15, 2026
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal

@mch2 mch2 Awaiting requested review from mch2

@msfroh msfroh Awaiting requested review from msfroh

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@reta reta Awaiting requested review from reta

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@sohami sohami Awaiting requested review from sohami

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

+2 more reviewers

@dblock dblock dblock left review comments

@rajiv-kv rajiv-kv rajiv-kv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch >breaking Identifies a breaking change. bug Something isn't working Cluster Manager

Projects

Cluster Manager Project Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] cluster.max_shards_per_node should have an upper limit

4 participants

@kkewwei @dblock @shwetathareja @rajiv-kv