[Backport 2.x] Adding QueryGroup schema (#13669)#14690
Merged
Merged
Conversation
* rebase with opensearch/main Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupId propagation logic from coordinator to data nodes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add sandbox schema Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupTests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupMetadata tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * run spotlessApply Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add mode field in ResourceLimitGroup schema Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix breaking testcases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add task cancellation skeleton Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add multitenant labels in searchSource builder Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * write custom xcontent parser for ResourceLimitGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unrelated changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove non-existing import fro cluster settings Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove non releated changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add _id as the resourceLimitGroup key Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add change to register resource limit group metadata Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add updatedAt in resource limit group Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename resourceLimitGroup to queryGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address the comments on PR Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename the mode member var to resiliency mode Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add change in CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add tests for custom namedWritable QueryGroupMetadata Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * structure resourceLimits into an object Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add QueryGroup.toXContent test case Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix precommit errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix precommit errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix assemble errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix checkstyle errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for fff79ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14690 +/- ##
==========================================
Coverage 71.42% 71.43%
- Complexity 62382 62435 +53
==========================================
Files 5103 5105 +2
Lines 293268 293454 +186
Branches 42730 42760 +30
==========================================
+ Hits 209478 209637 +159
+ Misses 66236 66203 -33
- Partials 17554 17614 +60 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Jul 9, 2024
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Assuming it's the same code just rebased. LMK if otherwise.
Contributor
Author
|
Yes, Thanks @dblock |
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#14690) * Adding QueryGroup schema (opensearch-project#13669) * rebase with opensearch/main Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupId propagation logic from coordinator to data nodes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add sandbox schema Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupTests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add resourceLimitGroupMetadata tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * run spotlessApply Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add mode field in ResourceLimitGroup schema Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix breaking testcases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add task cancellation skeleton Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add multitenant labels in searchSource builder Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * write custom xcontent parser for ResourceLimitGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unrelated changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove non-existing import fro cluster settings Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove non releated changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add _id as the resourceLimitGroup key Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add change to register resource limit group metadata Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add updatedAt in resource limit group Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename resourceLimitGroup to queryGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address the comments on PR Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename the mode member var to resiliency mode Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add change in CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add tests for custom namedWritable QueryGroupMetadata Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * structure resourceLimits into an object Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add QueryGroup.toXContent test case Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix precommit errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix precommit errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix assemble errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix checkstyle errors Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add min supported version in query group metadata Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: kkewwei <kkewwei@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport PR for original PR: #13669
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.