[Backport 2.x] Remove query categorization from core

[opensearch-trigger-bot]

Backport d351c58 from #14759.

[reta]

@deshsidd @ansjcy these changes made it to 2.15.0 so technically we are breaking things (that apparently we have never documented). @andrross @dblock fyi folks

[github-actions]

✅ Gradle check result for 942ba6d: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (697396b) to head (942ba6d).

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x   #14762      +/-   ##
============================================
- Coverage     71.61%   71.59%   -0.03%     
- Complexity    62504    62509       +5     
============================================
  Files          5106     5101       -5     
  Lines        293554   293427     -127     
  Branches      42772    42762      -10     
============================================
- Hits         210228   210077     -151     
- Misses        65688    65729      +41     
+ Partials      17638    17621      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kotwanikunal]

@deshsidd @ansjcy these changes made it to 2.15.0 so technically we are breaking things (that apparently we have never documented). @andrross @dblock fyi folks

Can we potentially treat it as a bug or miss for 2.15?

[deshsidd]

@reta We are moving these changes to the query insights plugin and will backport those changes too to keep things consistent. We will be documenting this as part of the plugin documentation. Please let us know your thoughts. Hope we can review and approve this one.

[reta]

@reta We are moving these changes to the query insights plugin and will backport those changes too to keep things consistent. We will be documenting this as part of the plugin documentation. Please let us know your thoughts. Hope we can review and approve this one.

Sure, but the plugins follow some conventions for settings, fe: search.query.metrics.enabled would become plugins.query-insigths.search.query.metrics.enabled

@andrross any concerns? (custom-codecs flashback :-) )

[deshsidd]

@reta Thanks for the approval. Please merge the PR as I don't have write permissions.

[deshsidd]

@reta We are moving these changes to the query insights plugin and will backport those changes too to keep things consistent. We will be documenting this as part of the plugin documentation. Please let us know your thoughts. Hope we can review and approve this one.

Sure, but the plugins follow some conventions for settings, fe: search.query.metrics.enabled would become plugins.query-insigths.search.query.metrics.enabled

@andrross any concerns? (custom-codecs flashback :-) )

Understood. We are using the name search.query.metrics.enabled in our downstream services and logic since OS 2.13. Might have to make multiple changes if we make this counter name change.

[reta]

Understood. We are using the name search.query.metrics.enabled in our downstream services and logic since OS 2.13. Might have to make multiple changes if we make this counter name change.

Yes, we would need to deprecate this property in favour of plugins.* specific one (we have many examples of such migrations).

[deshsidd]

Yes, we would need to deprecate this property in favour of plugins.* specific one (we have many examples of such migrations).

@reta Will do the rename as a followup PR which I will backport. Is it okay to merge this for now? Need it to make sure our builds pass for the plugin.