Skip to content

Backport: SPI for loading ABC templates (#14659)#14784

Merged
shwetathareja merged 3 commits intoopensearch-project:2.xfrom
mgodwan:managed-template-2.x
Jul 18, 2024
Merged

Backport: SPI for loading ABC templates (#14659)#14784
shwetathareja merged 3 commits intoopensearch-project:2.xfrom
mgodwan:managed-template-2.x

Conversation

@mgodwan
Copy link
Copy Markdown
Member

@mgodwan mgodwan commented Jul 17, 2024

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* SPI for loading ABC templates

Signed-off-by: mgodwan <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan force-pushed the managed-template-2.x branch from 77f7604 to 577f181 Compare July 17, 2024 05:33
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 77f7604: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 577f181: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan changed the title SPI for loading ABC templates (#14659) Backport: SPI for loading ABC templates (#14659) Jul 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c4f8717: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 317e512: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 84.39716% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (a6b8be1) to head (317e512).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...r/applicationtemplates/SystemTemplatesService.java 83.58% 8 Missing and 3 partials ⚠️
...r/applicationtemplates/SystemTemplateMetadata.java 62.50% 6 Missing ⚠️
...iontemplates/ClusterStateSystemTemplateLoader.java 89.18% 2 Missing and 2 partials ⚠️
server/src/main/java/org/opensearch/node/Node.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14784      +/-   ##
============================================
+ Coverage     71.58%   71.68%   +0.09%     
- Complexity    62462    62604     +142     
============================================
  Files          5106     5111       +5     
  Lines        293563   293709     +146     
  Branches      42772    42783      +11     
============================================
+ Hits         210160   210541     +381     
+ Misses        65744    65478     -266     
- Partials      17659    17690      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgodwan mgodwan requested a review from VachaShah as a code owner July 18, 2024 03:51
@shwetathareja shwetathareja merged commit f2cff08 into opensearch-project:2.x Jul 18, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14784)

* SPI for loading ABC templates (opensearch-project#14659)

* SPI for loading ABC templates

Signed-off-by: mgodwan <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants