Skip to content

Set version to 2.15 for determining metadata during migration to remote store#14819

Merged
ashking94 merged 1 commit into
opensearch-project:mainfrom
skumawat2025:migration-fix
Jul 18, 2024
Merged

Set version to 2.15 for determining metadata during migration to remote store#14819
ashking94 merged 1 commit into
opensearch-project:mainfrom
skumawat2025:migration-fix

Conversation

@skumawat2025
Copy link
Copy Markdown
Contributor

@skumawat2025 skumawat2025 commented Jul 18, 2024

Description

Set version to 2.15 for determining custom metadata during migration to remote store.

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…uringMigration

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 321f021: SUCCESS

@skumawat2025 skumawat2025 added the backport 2.x Backport to 2.x branch label Jul 18, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (4abcf39) to head (321f021).

Files Patch % Lines
.../org/opensearch/index/remote/RemoteStoreUtils.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14819      +/-   ##
============================================
- Coverage     71.91%   71.76%   -0.15%     
+ Complexity    62516    62426      -90     
============================================
  Files          5145     5145              
  Lines        293307   293307              
  Branches      42407    42407              
============================================
- Hits         210919   210499     -420     
- Misses        65040    65495     +455     
+ Partials      17348    17313      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94 ashking94 changed the title Correct Version Check in function determineRemoteStoreCustomMetadataD… Set version to 2.15 for determining metadata during migration to remote store Jul 18, 2024
@ashking94
Copy link
Copy Markdown
Member

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (4abcf39) to head (321f021).

Files Patch % Lines
.../org/opensearch/index/remote/RemoteStoreUtils.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

No change in code. The version should have been set earlier itself. Codecov warning is considering the changed lines and hence showing 0%. Going ahead with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants