Skip to content

[Backport 2.x] Implement write and read flow for shard diff file.#14915

Merged
dblock merged 1 commit intoopensearch-project:2.xfrom
shailendra0811:diff-pr
Jul 23, 2024
Merged

[Backport 2.x] Implement write and read flow for shard diff file.#14915
dblock merged 1 commit intoopensearch-project:2.xfrom
shailendra0811:diff-pr

Conversation

@shailendra0811
Copy link
Copy Markdown
Contributor

@shailendra0811 shailendra0811 commented Jul 23, 2024 •
edited
Loading

Backport f85a58f from #14684

@shailendra0811 shailendra0811 changed the title Diff pr [Backport 2.x] Implement write and read flow to upload/download shard diff file. Jul 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for ef4c0e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for 5bdd3df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file. [Backport 2.x] Implement write and read flow to upload/download shard diff file #14684 Jul 23, 2024
@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file #14684 [Backport 2.x] Implement write and read flow to upload/download shard diff file Jul 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for a8438c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shailendra0811
[Remote Routing Table] Implement write and read flow for shard diff f…
eb611c7 
…ile (opensearch-project#14684)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file [Backport 2.x] Implement write and read flow for shard diff file. Jul 23, 2024
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 23, 2024
Closed
74 tasks
ashking94
ashking94 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description with the typical message that is added to backport PRs. You can refer other manual backport PRs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

✅ Gradle check result for eb611c7: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 56 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (788a7fe) to head (eb611c7).
Report is 11 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 57.77% 14 Missing and 5 partials ⚠️
...h/cluster/routing/RoutingTableIncrementalDiff.java 82.97% 8 Missing ⚠️
...teway/remote/RemoteClusterStateCleanupManager.java 52.94% 6 Missing and 2 partials ⚠️
...ay/remote/routingtable/RemoteRoutingTableDiff.java 76.66% 4 Missing and 3 partials ⚠️
...earch/gateway/remote/ClusterStateDiffManifest.java 76.19% 2 Missing and 3 partials ⚠️
.../routing/remote/NoopRemoteRoutingTableService.java 57.14% 3 Missing ⚠️
...ster/routing/remote/RemoteRoutingTableService.java 76.92% 2 Missing and 1 partial ⚠️
...nsearch/gateway/remote/RemotePersistenceStats.java 60.00% 2 Missing ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14915      +/-   ##
============================================
+ Coverage     71.52%   71.54%   +0.01%     
- Complexity    62546    62637      +91     
============================================
  Files          5110     5120      +10     
  Lines        293684   294251     +567     
  Branches      42800    42876      +76     
============================================
+ Hits         210063   210515     +452     
- Misses        65978    66003      +25     
- Partials      17643    17733      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 39da9bd into opensearch-project:2.x Jul 23, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[Remote Routing Table] Implement write and read flow for shard diff f…
a4c1fe4 
…ile (#14684) (#14915)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
(cherry picked from commit 39da9bd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Closed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@shailendra0811 @kkewwei
[Remote Routing Table] Implement write and read flow for shard diff f…
93d0983 
…ile (opensearch-project#14684) (opensearch-project#14915)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
This was referenced Sep 6, 2024
Closed
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashking94 ashking94 ashking94 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

backport 2.16

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shailendra0811 @ashking94 @dblock @alchemist51