Skip to content

[Backport 2.x] Optimising hashmap.get call inside AwarenessAllocationDecider#14919

Merged
dblock merged 1 commit into2.xfrom
backport/backport-14761-to-2.x
Jul 23, 2024
Merged

[Backport 2.x] Optimising hashmap.get call inside AwarenessAllocationDecider#14919
dblock merged 1 commit into2.xfrom
backport/backport-14761-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 23, 2024

Backport e46d1d8 from #14761.

@github-actions
Optmising AwarenessAllocationDecider for hashmap.get call (#14761)
b53e0c7 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
(cherry picked from commit e46d1d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for b53e0c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for b53e0c7: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@prudhvigodithi prudhvigodithi mentioned this pull request Jul 23, 2024
Closed
74 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

❌ Gradle check result for b53e0c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2024

✅ Gradle check result for b53e0c7: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (788a7fe) to head (b53e0c7).
Report is 17 commits behind head on 2.x.

Files Patch % Lines
...allocation/decider/AwarenessAllocationDecider.java 82.60% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14919      +/-   ##
============================================
+ Coverage     71.52%   71.58%   +0.06%     
- Complexity    62546    62682     +136     
============================================
  Files          5110     5118       +8     
  Lines        293684   293963     +279     
  Branches      42800    42836      +36     
============================================
+ Hits         210063   210446     +383     
+ Misses        65978    65915      -63     
+ Partials      17643    17602      -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 3e7105b into 2.x Jul 23, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Optmising AwarenessAllocationDecider for hashmap.get call (opensearch…
b0ac95f 
…-project#14761) (opensearch-project#14919)

(cherry picked from commit e46d1d8)

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@dbwiddis dbwiddis deleted the backport/backport-14761-to-2.x branch July 24, 2024 16:03
This was referenced Sep 11, 2024
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashking94 ashking94 ashking94 approved these changes

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashking94 @Bukhtawar @dblock