Fix missing value of FieldSort for unsigned_long#14963
Merged
reta merged 3 commits intoopensearch-project:mainfrom Jul 30, 2024
Merged
Fix missing value of FieldSort for unsigned_long#14963reta merged 3 commits intoopensearch-project:mainfrom
reta merged 3 commits intoopensearch-project:mainfrom
Conversation
bugmakerrrrrr
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for a921fb8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 6777ca6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
requested changes
Jul 28, 2024
.../java/org/opensearch/index/fielddata/fieldcomparator/UnsignedLongValuesComparatorSource.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/fielddata/fieldcomparator/UnsignedLongValuesComparatorSource.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for e33606f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
@bugmakerrrrrr could you please resolve the conflicts? thank you |
reta
added
bug
bugmakerrrrrr
force-pushed
the
ul_missing
branch
from
e33606f to
f5544fb
Compare
Contributor
Author
Done |
Contributor
|
❕ Gradle check result for f5544fb: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14963 +/- ##
============================================
- Coverage 71.79% 71.79% -0.01%
+ Complexity 62736 62725 -11
============================================
Files 5161 5161
Lines 294368 294371 +3
Branches 42577 42578 +1
============================================
- Hits 211337 211330 -7
- Misses 65626 65691 +65
+ Partials 17405 17350 -55 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Jul 29, 2024
Contributor
|
@bugmakerrrrrr DCO check is failing sadly :( |
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
bugmakerrrrrr
force-pushed
the
ul_missing
branch
from
f5544fb to
896e850
Compare
Contributor
reta
approved these changes
Jul 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Fix missing value of FieldSort for unsigned_long Signed-off-by: panguixin <panguixin@bytedance.com> * add changelog Signed-off-by: panguixin <panguixin@bytedance.com> * apply review comments Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit ffa67f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Fix missing value of FieldSort for unsigned_long * add changelog * apply review comments --------- (cherry picked from commit ffa67f9) Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…14963) * Fix missing value of FieldSort for unsigned_long Signed-off-by: panguixin <panguixin@bytedance.com> * add changelog Signed-off-by: panguixin <panguixin@bytedance.com> * apply review comments Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…14963) * Fix missing value of FieldSort for unsigned_long Signed-off-by: panguixin <panguixin@bytedance.com> * add changelog Signed-off-by: panguixin <panguixin@bytedance.com> * apply review comments Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com>
This was referenced Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two changes here:
ClassCastExceptionwill be thrown(class java.lang.Integer cannot be cast to class java.math.BigInteger).Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.