Skip to content

Use clusterUUID for discovery nodes remote path#15143

Merged
Bukhtawar merged 1 commit intoopensearch-project:mainfrom
soosinha:nodes-path
Aug 14, 2024
Merged

Use clusterUUID for discovery nodes remote path#15143
Bukhtawar merged 1 commit intoopensearch-project:mainfrom
soosinha:nodes-path

Conversation

@soosinha
Copy link
Copy Markdown
Member

@soosinha soosinha commented Aug 7, 2024

Description

DiscoveryNodes is being uploaded as part of remote cluster state. The remote path for this object is being constructed using stateUUID. Cluster UUID should be used for the path instead.

Related Issues

#15142

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024

❌ Gradle check result for e4a5855: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024

✅ Gradle check result for 225bb90: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.81%. Comparing base (c725431) to head (225bb90).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15143      +/-   ##
============================================
- Coverage     71.85%   71.81%   -0.04%     
+ Complexity    62832    62786      -46     
============================================
  Files          5169     5169              
  Lines        294688   294688              
  Branches      42616    42616              
============================================
- Hits         211735   211623     -112     
- Misses        65561    65667     +106     
- Partials      17392    17398       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming manifest will reflect the real path and so we are good with BWC? Does GC will automatically use the new path based on manifest as well?

@soosinha
Copy link
Copy Markdown
Member Author

soosinha commented Aug 7, 2024

I am assuming manifest will reflect the real path and so we are good with BWC? Does GC will automatically use the new path based on manifest as well?

Yes. The manifest contains the actual path. The entities are downloaded by reading the manifest file. So bwc should not be impacted. GC also uses the path from manifest.

@Bukhtawar Bukhtawar merged commit 68bdb77 into opensearch-project:main Aug 14, 2024
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Aug 14, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 14, 2024
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 68bdb77)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar pushed a commit that referenced this pull request Aug 14, 2024
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…5143)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@soosinha soosinha deleted the nodes-path branch December 20, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants