Fix CHANGELOG for #15054#15150
Merged
jed326 merged 1 commit intoopensearch-project:mainfrom Aug 7, 2024
Merged
Conversation
jed326
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Contributor
Author
9 tasks
jainankitk
approved these changes
Aug 7, 2024
Contributor
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Ah, my bad! Missed it while reviewing #15054!
peternied
approved these changes
Aug 7, 2024
Member
|
@jed326 We actually have enforcement that if you add an entry in CHANGELOG.md but do not have a backport label then this check fails. I think we could add enforcement for this case: if there is an entry in CHANGELOG-3.0.md then there must not be a backport label. Any interest in adding that check? |
Contributor
Author
|
@andrross sure I can take that up in a day or two, good callout! |
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Jay Deng <jayd0104@gmail.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Jay Deng <jayd0104@gmail.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Jay Deng <jayd0104@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changelog item for #15054 should not be in
CHANGELOG-3.0.mdas it was backported to2.xin #15129Check List
- [ ] Functionality includes testing.- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.