Replace and block usages of org.apache.logging.log4j.util.Strings#15238
Merged
dblock merged 2 commits intoopensearch-project:mainfrom Aug 14, 2024
Merged
Replace and block usages of org.apache.logging.log4j.util.Strings#15238dblock merged 2 commits intoopensearch-project:mainfrom
dblock merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Contributor
|
❌ Gradle check result for cba60b2: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15238 +/- ##
=========================================
Coverage 71.89% 71.89%
- Complexity 63043 63071 +28
=========================================
Files 5197 5197
Lines 295311 295311
Branches 42676 42677 +1
=========================================
+ Hits 212314 212316 +2
- Misses 65552 65598 +46
+ Partials 17445 17397 -48 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Aug 14, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15238-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d74e276af68edbc5caf382fd2e61f11b9935c221
# Push it to GitHub
git push --set-upstream origin backport/backport-15238-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
Member
|
@cwperks backport manually please? |
cwperks
added a commit
to cwperks/OpenSearch
that referenced
this pull request
Aug 14, 2024
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit d74e276)
Member
Author
5 tasks
vibrantvarun
added a commit
to vibrantvarun/neural-search
that referenced
this pull request
Aug 21, 2024
…rch Core Signed-off-by: Varun Jain <varunudr@amazon.com>
vibrantvarun
added a commit
to opensearch-project/neural-search
that referenced
this pull request
Aug 21, 2024
* Upgrade BWC version and fix neural search build (#868) Signed-off-by: Varun Jain <varunudr@amazon.com> * Incrementing opensearch version to 2.17.0-SNAPSHOT Signed-off-by: Varun Jain <varunudr@amazon.com> * Incorporate fix from opensearch-project/OpenSearch#15238 from OpenSearch Core Signed-off-by: Varun Jain <varunudr@amazon.com> * Address Naveen's comment Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces usages of
org.apache.logging.log4j.util.Stringsandjoptsimple.internal.Stringswithorg.opensearch.core.common.Strings. This PR also makes the classes forbidden to prevent the precommit check from passing if there are any usages oforg.apache.logging.log4j.util.Stringsorjoptsimple.internal.Strings.Related Issues
Resolves #15211
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.