add query group stats constructs by kaushalmahi12 · Pull Request #15343 · opensearch-project/OpenSearch

kaushalmahi12 · 2024-08-21T22:25:41Z

Author: Kaushal Kumar

Description

This change introduces constructs to hold live view of query group level stats and point in time view of query group stats. Post these changes we will need changes to hook these constructs with various request events i,e; completions, failures, cancellations and rejections.

Related Issues

Resolves ##15120
RFC: #12342

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-08-21T23:19:31Z

❌ Gradle check result for 9f34c30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-21T23:25:48Z

❌ Gradle check result for 52330cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-22T18:34:36Z

❌ Gradle check result for 31f5405: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

jainankitk · 2024-08-26T22:02:33Z

Also, gradle precommit is failing for this PR

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions · 2024-08-28T01:59:12Z

✅ Gradle check result for 1df409f: SUCCESS

github-actions · 2024-08-28T02:15:59Z

❌ Gradle check result for 353b1c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-28T02:21:10Z

✅ Gradle check result for 4f6ee7a: SUCCESS

codecov · 2024-08-28T02:22:10Z

Codecov Report

Attention: Patch coverage is 89.18919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (c771bdd) to head (4f6ee7a).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/org/opensearch/wlm/stats/QueryGroupStats.java	87.20%	4 Missing and 7 partials ⚠️
...java/org/opensearch/wlm/stats/QueryGroupState.java	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15343      +/-   ##
============================================
- Coverage     71.95%   71.87%   -0.09%     
- Complexity    63286    63302      +16     
============================================
  Files          5225     5227       +2     
  Lines        296215   296323     +108     
  Branches      42788    42800      +12     
============================================
- Hits         213133   212971     -162     
- Misses        65559    65892     +333     
+ Partials      17523    17460      -63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit c0bcacb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* add query group stats constructs * add changelog entry * add packageinfo for stats * add total cancellations * add more granular level rejections * add toXContent test cases * move ResourceType enum to wlm * update the comment for query group stats --------- (cherry picked from commit c0bcacb) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This reverts commit c63ad5a.

This reverts commit c63ad5a. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

kaushalmahi12 added the backport 2.x Backport to 2.x branch label Aug 21, 2024

kaushalmahi12 added 3 commits August 22, 2024 15:36

add query group stats constructs

c34aa0e

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

add changelog entry

676096f

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

add packageinfo for stats

7fada74

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

kaushalmahi12 force-pushed the feature/sandbox-stats_constructs branch from 31f5405 to 7fada74 Compare August 22, 2024 22:37

kaushalmahi12 added 4 commits August 27, 2024 17:39

add more granular level rejections

a783e8f

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

add toXContent test cases

c53daf8

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

Merge branch 'main' into feature/sandbox-stats_constructs

1df409f

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

move ResourceType enum to wlm

353b1c8

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

kaushalmahi12 requested a review from jed326 as a code owner August 28, 2024 01:20

update the comment for query group stats

4f6ee7a

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

jainankitk approved these changes Aug 28, 2024

View reviewed changes

jainankitk merged commit c0bcacb into opensearch-project:main Aug 28, 2024

opensearch-trigger-bot Bot mentioned this pull request Aug 28, 2024

[Backport 2.x] add query group stats constructs #15473

Merged

reta added a commit that referenced this pull request Aug 28, 2024

Revert "Add query group stats constructs (#15343) (#15473)"

7ddcf80

This reverts commit c63ad5a.

reta added a commit that referenced this pull request Aug 28, 2024

Revert "Add query group stats constructs (#15343) (#15473)"

9cd2635

This reverts commit c63ad5a. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

BrewTestBot mentioned this pull request Sep 18, 2024

opensearch 2.17.0 Homebrew/homebrew-core#191052

Merged

prudhvigodithi mentioned this pull request Oct 16, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT prudhvigodithi/opensearch-build#82

Open

opensearch-ci-bot mentioned this pull request Sep 18, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndicesStoreIntegrationIT #14472

Open

opensearch-ci-bot mentioned this pull request Apr 27, 2026

[AUTOCUT] Gradle Check Flaky Test Report for RemoteSplitIndexIT #21393

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add query group stats constructs#15343

add query group stats constructs#15343
jainankitk merged 9 commits into
opensearch-project:mainfrom
kaushalmahi12:feature/sandbox-stats_constructs

kaushalmahi12 commented Aug 21, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 21, 2024

Uh oh!

github-actions Bot commented Aug 21, 2024

Uh oh!

github-actions Bot commented Aug 22, 2024

Uh oh!

jainankitk commented Aug 26, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

codecov Bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kaushalmahi12 commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions Bot commented Aug 21, 2024

Uh oh!

github-actions Bot commented Aug 21, 2024

Uh oh!

github-actions Bot commented Aug 22, 2024

Uh oh!

jainankitk commented Aug 26, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

github-actions Bot commented Aug 28, 2024

Uh oh!

codecov Bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kaushalmahi12 commented Aug 21, 2024 •

edited

Loading

codecov Bot commented Aug 28, 2024 •

edited

Loading