Removed suspicious getClass() call on Class

[dk2k]

Removed suspicious getClass() call on Class

[github-actions]

❌ Gradle check result for 34d23d1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

Is there a test covering this path?

[github-actions]

✅ Gradle check result for 34d23d1: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (abb1041) to head (34d23d1).
Report is 171 commits behind head on main.

Files with missing lines	Patch %	Lines
...rg/opensearch/core/common/io/stream/Writeable.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15367      +/-   ##
============================================
- Coverage     71.93%   71.84%   -0.09%     
+ Complexity    63223    63209      -14     
============================================
  Files          5214     5214              
  Lines        295938   295938              
  Branches      42754    42754              
============================================
- Hits         212876   212627     -249     
- Misses        65601    65880     +279     
+ Partials      17461    17431      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

Reading the code seems like the .getClass() was intentional. I could be wrong.

[dbwiddis]

Why is this suspicious?

The intention here is to display the fully qualified class name. Printing the instance toString() may expose object internals to an exception handling path.

[dk2k]

@dbwiddis
Code snippet for illustration:

public static void main(String[] args) {
    StringBuilder stringBuilder = new StringBuilder();
    Class classInstance = stringBuilder.getClass();
    System.out.println(classInstance);
    System.out.println(classInstance.getClass());
}

output:
class java.lang.StringBuilder
class java.lang.Class

Which of the lines from this output do you expect to see as part of exception's message?

[dblock]

The log entry says "streamable custom class XYZ already registered", we expect to see XYZ