Skip to content

[Backport 2.x] Throw UnsupportedOperationException in unused methods#15449

Merged
reta merged 1 commit into2.xfrom
backport/backport-15446-to-2.x
Aug 28, 2024
Merged

[Backport 2.x] Throw UnsupportedOperationException in unused methods#15449
reta merged 1 commit into2.xfrom
backport/backport-15446-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 27, 2024

Backport 20ebe6e from #15446.

@github-actions
Throw UnsupportedOperationException in unused methods (#15446)
3cd2bdd 
These methods infinitely recurse as currently implemented. This change
makes them throw UnsupportedOperationException similar to many other
methods in this class.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 20ebe6e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2024

❌ Gradle check result for 3cd2bdd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2024

❌ Gradle check result for 3cd2bdd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2024

❌ Gradle check result for 3cd2bdd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

✅ Gradle check result for 3cd2bdd: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (e80c06e) to head (3cd2bdd).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rg/opensearch/index/engine/TranslogLeafReader.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15449      +/-   ##
============================================
- Coverage     71.64%   71.64%   -0.01%     
- Complexity    63462    63477      +15     
============================================
  Files          5213     5213              
  Lines        297357   297357              
  Branches      43283    43283              
============================================
- Hits         213042   213035       -7     
- Misses        66497    66498       +1     
- Partials      17818    17824       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit d7e7d94 into 2.x Aug 28, 2024
This was referenced Sep 6, 2024
Closed
Open
Open
Open
@andrross andrross deleted the backport/backport-15446-to-2.x branch October 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reta