Fix missing order field in TemplatesMetadata deserialization#15509
Merged
Conversation
soosinha
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Bukhtawar
reviewed
Aug 29, 2024
Contributor
|
❌ Gradle check result for ed48b59: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
soosinha
force-pushed
the
templates-bug
branch
from
ed48b59 to
0915cb4
Compare
Contributor
|
❌ Gradle check result for 0915cb4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
soosinha
force-pushed
the
templates-bug
branch
from
0915cb4 to
8e7b724
Compare
Contributor
|
❕ Gradle check result for 8e7b724: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15509 +/- ##
============================================
- Coverage 71.92% 71.92% -0.01%
- Complexity 63483 63496 +13
============================================
Files 5244 5244
Lines 296911 296910 -1
Branches 42879 42879
============================================
- Hits 213557 213552 -5
- Misses 65799 65837 +38
+ Partials 17555 17521 -34 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
Signed-off-by: Sooraj Sinha <soosinha@amazon.com> (cherry picked from commit bcd09ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
This was referenced Apr 14, 2025
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
orderfield is missing while deserializing TemplatesMetadata object. This is because it is the first field in the serialized content and we are moving to the next token just before deserialization.Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.