Skip to content

Add validation on context template removal#15608

Open
mgodwan wants to merge 3 commits intoopensearch-project:mainfrom
mgodwan:handle-context-templ-removal
Open

Add validation on context template removal#15608
mgodwan wants to merge 3 commits intoopensearch-project:mainfrom
mgodwan:handle-context-templ-removal

Conversation

@mgodwan
Copy link
Copy Markdown
Member

@mgodwan mgodwan commented Sep 3, 2024

Description

Prevent removal of system templates used via context in indices.

Related Issues

Prevent removal of system templates used via context in indices.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 6a90a58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan self-assigned this Sep 3, 2024
@mgodwan mgodwan added Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog labels Sep 3, 2024
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 4a8cf94: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan requested a review from VachaShah as a code owner September 3, 2024 11:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 57522c6: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2024

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.91%. Comparing base (a5590d1) to head (57522c6).
⚠️ Report is 1794 commits behind head on main.

Files with missing lines Patch % Lines
...cluster/metadata/MetadataIndexTemplateService.java 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15608      +/-   ##
============================================
+ Coverage     71.85%   71.91%   +0.06%     
- Complexity    63847    63904      +57     
============================================
  Files          5257     5257              
  Lines        298543   298555      +12     
  Branches      43164    43165       +1     
============================================
+ Hits         214507   214720     +213     
+ Misses        66421    66222     -199     
+ Partials      17615    17613       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Oct 3, 2024
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Nov 5, 2024
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Dec 14, 2024
@andrross
Copy link
Copy Markdown
Member

andrross commented Mar 5, 2026

@mgodwan Is this still relevant or should it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog stalled Issues that have stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants