[RW Separation] Add polling segment replication for search replicas#15627
Merged
mch2 merged 8 commits intoopensearch-project:mainfrom Sep 5, 2024
Merged
[RW Separation] Add polling segment replication for search replicas#15627mch2 merged 8 commits intoopensearch-project:mainfrom
mch2 merged 8 commits intoopensearch-project:mainfrom
Conversation
mch2
commented
Sep 3, 2024
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
❕ Gradle check result for aef15f9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This PR introduces polling for search replicas at the existing refresh interval. If any index has a search replica will trigger segrep on an interval. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15627-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 375c0bf1c9ac9ff7226d447bcd1dddfcedd856fc
# Push it to GitHub
git push --set-upstream origin backport/backport-15627-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15627-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 375c0bf1c9ac9ff7226d447bcd1dddfcedd856fc
# Push it to GitHub
git push --set-upstream origin backport/backport-15627-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17Then, create a pull request where the |
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15627) (cherry picked from commit 375c0bf)
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93)
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
mch2
added a commit
that referenced
this pull request
Sep 5, 2024
mch2
added a commit
that referenced
this pull request
Sep 5, 2024
…earch replicas (#15627) (#15718) * [RW Separation] Add polling segment replication for search replicas (#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * fix compilation from extra ctors on 2.x line Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add segment replication polling for search replicas. This PR introduces segrep polling for search replicas at the existing refresh interval. If the feature flag is enabled an async task from IndexService will trigger replication.
Related Issues
Related #4577
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.