Skip to content

[Backport 2.17] Add cluster state checksum in manifest #15218#15658

Merged
Bukhtawar merged 4 commits into
opensearch-project:2.17from
himshikha:remote-checksum-2.17
Sep 4, 2024
Merged

[Backport 2.17] Add cluster state checksum in manifest #15218#15658
Bukhtawar merged 4 commits into
opensearch-project:2.17from
himshikha:remote-checksum-2.17

Conversation

@himshikha
Copy link
Copy Markdown

@himshikha himshikha commented Sep 4, 2024

Description

Backport of #15218

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

himshikhagupta and others added 4 commits September 4, 2024 14:51
@himshikhagupta @Bukhtawar
Add cluster state checksum in manifest (opensearch-project#15218)
57168df 
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Co-authored-by: Bukhtawar Khan <bukhtawa@amazon.com>
@himshikhagupta
bwc fix
7128178 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@himshikhagupta
removing verifiableWriteable interface
b900437 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@himshikhagupta
spotless
0c5535b 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

✅ Gradle check result for 0c5535b: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.46809% with 132 lines in your changes missing coverage. Please review.

Project coverage is 71.63%. Comparing base (6194bbd) to head (0c5535b).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 33.33% 54 Missing and 10 partials ⚠️
...main/java/org/opensearch/cluster/ClusterState.java 4.00% 24 Missing ⚠️
...pensearch/gateway/remote/ClusterStateChecksum.java 94.36% 6 Missing and 6 partials ⚠️
...h/index/translog/BufferedChecksumStreamOutput.java 72.09% 12 Missing ⚠️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 58.33% 1 Missing and 9 partials ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 85.18% 1 Missing and 3 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 82.35% 3 Missing ⚠️
.../java/org/opensearch/cluster/AbstractDiffable.java 0.00% 1 Missing ⚠️
...org/opensearch/cluster/metadata/IndexMetadata.java 94.73% 0 Missing and 1 partial ⚠️
...opensearch/cluster/metadata/TemplatesMetadata.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.17   #15658      +/-   ##
============================================
- Coverage     71.68%   71.63%   -0.05%     
- Complexity    64081    64130      +49     
============================================
  Files          5248     5249       +1     
  Lines        299521   300022     +501     
  Branches      43609    43653      +44     
============================================
+ Hits         214698   214930     +232     
- Misses        66881    67100     +219     
- Partials      17942    17992      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 175cbd0 into opensearch-project:2.17 Sep 4, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@himshikha @Bukhtawar @himshikhagupta