Add restriction to have a single repository with shallow snapshot v2 setting#15901
Merged
sachinpkale merged 2 commits intoopensearch-project:mainfrom Sep 12, 2024
Merged
Conversation
1526597 to
c57c9c2
Compare
Contributor
…setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
c57c9c2 to
0d86005
Compare
Contributor
|
❕ Gradle check result for c57c9c2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15901 +/- ##
============================================
+ Coverage 71.90% 72.01% +0.10%
- Complexity 64216 64311 +95
============================================
Files 5272 5272
Lines 300597 300636 +39
Branches 43440 43449 +9
============================================
+ Hits 216151 216499 +348
+ Misses 66680 66422 -258
+ Partials 17766 17715 -51 ☔ View full report in Codecov by Sentry. |
ashking94
reviewed
Sep 12, 2024
server/src/main/java/org/opensearch/repositories/RepositoriesService.java
Show resolved
Hide resolved
sachinpkale
commented
Sep 12, 2024
server/src/main/java/org/opensearch/repositories/RepositoriesService.java
Outdated
Show resolved
Hide resolved
…_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Contributor
Bukhtawar
reviewed
Sep 12, 2024
server/src/main/java/org/opensearch/repositories/RepositoriesService.java
Show resolved
Hide resolved
Bukhtawar
reviewed
Sep 12, 2024
server/src/main/java/org/opensearch/repositories/RepositoriesService.java
Show resolved
Hide resolved
Bukhtawar
approved these changes
Sep 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…setting (#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> (cherry picked from commit 330b249) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…setting (#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> (cherry picked from commit 330b249) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
added a commit
that referenced
this pull request
Sep 12, 2024
…low snapshot v2 setting (#15911) * Add restriction to have a single repository with shallow snapshot v2 setting (#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> (cherry picked from commit 330b249) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add a method to avoid breaking changes Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
sachinpkale
added a commit
that referenced
this pull request
Sep 12, 2024
…ow snapshot v2 setting (#15912) * Add restriction to have a single repository with shallow snapshot v2 setting (#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> (cherry picked from commit 330b249) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add a method to avoid breaking changes Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…setting (opensearch-project#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…setting (opensearch-project#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…setting (opensearch-project#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…setting (opensearch-project#15901) * Add restriction to have a single repository with shallow snapshot v2 setting Signed-off-by: Sachin Kale <sachinpkale@gmail.com> * Do not allow shallow snapshot v2 repo name to contain SNAPSHOT_PINNED_TIMESTAMP_DELIMITER Signed-off-by: Sachin Kale <sachinpkale@gmail.com> --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.