Fix flaky terminaton conditions for org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case#15959
Merged
reta merged 1 commit intoopensearch-project:mainfrom Sep 17, 2024
Conversation
…StreamingStressIT.testCloseClientStreamingRequest test case Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
Author
|
@mch2 may I ask you please to take a look? thank you! |
Contributor
|
❌ Gradle check result for 85ebbb0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mch2
approved these changes
Sep 17, 2024
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15959 +/- ##
============================================
- Coverage 71.93% 71.84% -0.10%
+ Complexity 64374 64306 -68
============================================
Files 5277 5277
Lines 300828 300828
Branches 43474 43474
============================================
- Hits 216411 216126 -285
- Misses 66725 66953 +228
- Partials 17692 17749 +57 ☔ View full report in Codecov by Sentry. |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15959-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb5b70370e548cd0f3b51721397df818b3050daa
# Push it to GitHub
git push --set-upstream origin backport/backport-15959-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Sep 17, 2024
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit eb5b703)
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 19, 2024
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…StreamingStressIT.testCloseClientStreamingRequest test case (opensearch-project#15959) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup on this comment #15859 (comment), removal of the
ConnectionClosedExceptionwas premature:Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.