Remove redundant force merge in rest tests#16144
Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom Oct 9, 2024
Merged
Remove redundant force merge in rest tests#16144jainankitk merged 1 commit intoopensearch-project:mainfrom
jainankitk merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16144 +/- ##
============================================
+ Coverage 71.86% 72.01% +0.15%
- Complexity 64447 64492 +45
============================================
Files 5288 5288
Lines 301438 301439 +1
Branches 43552 43552
============================================
+ Hits 216628 217087 +459
+ Misses 67034 66489 -545
- Partials 17776 17863 +87 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@jainankitk can you take a look? Per conversation here: #16083 (comment) |
Contributor
Thanks @finnegancarroll for following up the discussion with this PR! |
jainankitk
approved these changes
Oct 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Finn Carroll <carrofin@amazon.com> (cherry picked from commit a09750a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit a09750a) Signed-off-by: Finn Carroll <carrofin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…6144) Signed-off-by: Finn Carroll <carrofin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several aggregation rest tests assert on the number of optimized segments.
- match: { profile.shards.0.aggregations.0.debug.optimized_segments: 1 }For these tests to be consistent our index can only have a single segment. As such we configure out test indices with 1 shard and no refresh interval to ensure a single segment.
We also force merge in these cases:
These two operations are redundant so this pr removes the force merge step for these cases.
Related Issues
Inciting comment
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.