[Snapshot V2] Remove orphan timestamps post create snapshot completion#16148
Merged
gbbafna merged 3 commits intoopensearch-project:mainfrom Oct 3, 2024
Merged
[Snapshot V2] Remove orphan timestamps post create snapshot completion#16148gbbafna merged 3 commits intoopensearch-project:mainfrom
gbbafna merged 3 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 0503f63: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
reviewed
Oct 1, 2024
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java
Show resolved
Hide resolved
gbbafna
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
saratvemulapalli,
shwetathareja and
sohami
as code owners
sachinpkale
reviewed
Oct 1, 2024
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for d045995: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 1, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Contributor
|
❌ Gradle check result for 1cfb6c7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale
approved these changes
Oct 3, 2024
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16148 +/- ##
============================================
+ Coverage 71.91% 72.08% +0.17%
- Complexity 64491 64590 +99
============================================
Files 5289 5289
Lines 301509 301559 +50
Branches 43557 43563 +6
============================================
+ Hits 216818 217370 +552
+ Misses 66892 66393 -499
+ Partials 17799 17796 -3 ☔ View full report in Codecov by Sentry. |
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
opensearch-project#16148) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
opensearch-project#16148) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
opensearch-project#16148) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
opensearch-project#16148) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We update pinned timestamps before finalizing the snapshot . In case post pinning timestamp, finalizing snapshot can fail . This leads to orphan pinned timestamps. This will leak data in remote store.
In this change, post every create snapshot operation, we find the orphan pinned timestamps and then unpin it .
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.