Skip to content

[Backport 2.x] Close RemoteStorePinnedTimestampService on Node.close()#16234

Merged
gbbafna merged 1 commit into2.xfrom
backport/backport-16228-to-2.x
Oct 8, 2024
Merged

[Backport 2.x] Close RemoteStorePinnedTimestampService on Node.close()#16234
gbbafna merged 1 commit into2.xfrom
backport/backport-16228-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 8, 2024

Backport 96082f7 from #16228.

@github-actions
Close RemoteStorePinnedTimestampService on Node.close() (#16228)
d688f9b 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 96082f7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for d688f9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for d688f9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 8, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

❕ Gradle check result for d688f9b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (704e498) to head (d688f9b).
Report is 5 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##                2.x   #16234    +/-   ##
==========================================
  Coverage     71.72%   71.73%            
- Complexity    64773    64955   +182     
==========================================
  Files          5284     5293     +9     
  Lines        303053   303455   +402     
  Branches      44086    44138    +52     
==========================================
+ Hits         217372   217686   +314     
- Misses        67457    67583   +126     
+ Partials      18224    18186    -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 6ba121e into 2.x Oct 8, 2024
@github-actions github-actions bot deleted the backport/backport-16228-to-2.x branch October 8, 2024 13:19
This was referenced Oct 8, 2024
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachinpkale @gbbafna