BugFix: call listener.onFailure on failure to pin the timestamp

[sachinpkale]

Description

• Today, if we try to pin the timestamp that is older than now() - Lookbak Interval, we throw IllegalArgumentException
• But as RemoteStorePinnedTimestampService.pinTimestamp is async, on any failure, listener.onFailure() should be called.
  

  OpenSearch/server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java

  Lines 132 to 140 in acf209f

  	public void pinTimestamp(long timestamp, String pinningEntity, ActionListener<Void> listener) {
  	// If a caller uses current system time to pin the timestamp, following check will almost always fail.
  	// So, we allow pinning timestamp in the past upto some buffer
  	long lookbackIntervalInMills = RemoteStoreSettings.getPinnedTimestampsLookbackInterval().millis();
  	if (timestamp < (System.currentTimeMillis() - lookbackIntervalInMills)) {
  	throw new IllegalArgumentException(
  	"Timestamp to be pinned is less than current timestamp - value of cluster.remote_store.pinned_timestamps.lookback_interval"
  	);
  	}

• Due to this, caller will keep waiting on listener.
• In this PR, we make sure to call listener.onFailure on each type of failure

Related Issues

• [BUG] listener.onFailure is not called on failure to pin the older timestamp #16247

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 8854340: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d627609: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d627609: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 1466a73: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (e7757e7) to head (1466a73).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...remotestore/RemoteStorePinnedTimestampService.java	28.57%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16248      +/-   ##
============================================
+ Coverage     71.97%   72.01%   +0.03%     
+ Complexity    64771    64741      -30     
============================================
  Files          5302     5302              
  Lines        302473   302473              
  Branches      43699    43699              
============================================
+ Hits         217715   217832     +117     
+ Misses        66950    66754     -196     
- Partials      17808    17887      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.