Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode by imRishN · Pull Request #16299 · opensearch-project/OpenSearch

imRishN · 2024-10-13T08:23:37Z

Description

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode

Related Issues

Master hot thread -

app//org.opensearch.cluster.routing.allocation.decider.RemoteStoreMigrationAllocationDecider.getDecisionDetails(RemoteStoreMigrationAllocationDecider.java:196)
       app//org.opensearch.cluster.routing.allocation.decider.RemoteStoreMigrationAllocationDecider.canAllocate(RemoteStoreMigrationAllocationDecider.java:94)
       app//org.opensearch.cluster.routing.allocation.decider.AllocationDeciders.canAllocate(AllocationDeciders.java:94)
       app//org.opensearch.cluster.routing.allocation.allocator.LocalShardsBalancer.decideAllocateUnassigned(LocalShardsBalancer.java:980)
       app//org.opensearch.cluster.routing.allocation.allocator.LocalShardsBalancer.allocateUnassigned(LocalShardsBalancer.java:866)
       app//org.opensearch.cluster.routing.allocation.allocator.BalancedShardsAllocator.allocate(BalancedShardsAllocator.java:353)
       app//org.opensearch.cluster.routing.allocation.AllocationService.reroute(AllocationService.java:575)
       app//org.opensearch.cluster.routing.allocation.AllocationService.reroute(AllocationService.java:542)
       app//org.opensearch.cluster.routing.allocation.AllocationService.disassociateDeadNodes(AllocationService.java:353)
       app//org.opensearch.cluster.coordination.NodeRemovalClusterStateTaskExecutor.getTaskClusterTasksResult(NodeRemovalClusterStateTaskExecutor.java:123)
       app//org.opensearch.cluster.coordination.NodeRemovalClusterStateTaskExecutor.execute(NodeRemovalClusterStateTaskExecutor.java:113)
       app//org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:912)
       app//org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:464)
       app//org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:324)
       app//org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:228)
       app//org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:215)
       app//org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:257)
       app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:891)

Check List

~~[ ] Functionality includes testing.~~
~~[ ] API changes companion pull request created, if applicable.~~
~~[ ] Public documentation issue/PR created, if applicable.~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…er when not in debug mode Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java

Bukhtawar

cc: @gbbafna @shourya035 for help with review

github-actions · 2024-10-13T08:57:49Z

❌ Gradle check result for 60c167c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

github-actions · 2024-10-13T19:35:07Z

✅ Gradle check result for 13627a0: SUCCESS

codecov · 2024-10-13T19:35:46Z

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (20536ee) to head (13627a0).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...decider/RemoteStoreMigrationAllocationDecider.java	83.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16299      +/-   ##
============================================
+ Coverage     72.00%   72.06%   +0.05%     
- Complexity    64796    64846      +50     
============================================
  Files          5307     5307              
  Lines        302540   302543       +3     
  Branches      43708    43708              
============================================
+ Hits         217853   218021     +168     
+ Misses        66801    66634     -167     
- Partials      17886    17888       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis

LGTM with a minor nit.

...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java

…er when not in debug mode (#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> (cherry picked from commit 5d2d392) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…er when not in debug mode (#16299) (#16301) (cherry picked from commit 5d2d392) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…er when not in debug mode (opensearch-project#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…

60c167c

…er when not in debug mode Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

imRishN added the skip-changelog label Oct 13, 2024

Bukhtawar reviewed Oct 13, 2024

View reviewed changes

...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java Outdated Show resolved Hide resolved

Bukhtawar reviewed Oct 13, 2024

View reviewed changes

Fix

13627a0

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

dbwiddis approved these changes Oct 13, 2024

View reviewed changes

...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java Show resolved Hide resolved

gbbafna approved these changes Oct 14, 2024

View reviewed changes

gbbafna merged commit 5d2d392 into opensearch-project:main Oct 14, 2024

gbbafna added the backport 2.x Backport to 2.x branch label Oct 14, 2024

opensearch-trigger-bot bot mentioned this pull request Oct 14, 2024

[Backport 2.x] Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode #16301

Merged

opensearch-ci-bot mentioned this pull request Oct 12, 2024

[AUTOCUT] Gradle Check Flaky Test Report for SpecificClusterManagerNodesIT #15944

Closed

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024

Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…

665daa8

…er when not in debug mode (opensearch-project#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024

Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…

43505c9

…er when not in debug mode (opensearch-project#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024

Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…

4c22df0

…er when not in debug mode (opensearch-project#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025

Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…

ca54fb2

…er when not in debug mode (opensearch-project#16299) Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode#16299

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode#16299
gbbafna merged 2 commits intoopensearch-project:mainfrom
imRishN:decider-opt

imRishN commented Oct 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

Bukhtawar left a comment

Uh oh!

github-actions bot commented Oct 13, 2024

Uh oh!

github-actions bot commented Oct 13, 2024

Uh oh!

codecov bot commented Oct 13, 2024 •

edited

Loading

Uh oh!

dbwiddis left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

imRishN commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

Uh oh!

Bukhtawar left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 13, 2024

Uh oh!

github-actions bot commented Oct 13, 2024

Uh oh!

codecov bot commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbwiddis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

imRishN commented Oct 13, 2024 •

edited

Loading

codecov bot commented Oct 13, 2024 •

edited

Loading