Skip to content

[NOCOMMIT] Approximate match all query benchmark#16322

Closed
msfroh wants to merge 2 commits intoopensearch-project:mainfrom
msfroh:approximate_MatchAllQuery_benchmark
Closed

[NOCOMMIT] Approximate match all query benchmark#16322
msfroh wants to merge 2 commits intoopensearch-project:mainfrom
msfroh:approximate_MatchAllQuery_benchmark

Conversation

@msfroh
Copy link
Copy Markdown
Contributor

@msfroh msfroh commented Oct 14, 2024

Description

This PR accompanies #16321 and adds a throwaway benchmark workload that enables range query approximation, to check if the changes there have the desired effect of reducing latency on match_all queries with a sort over a numeric field.

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

If we run a match-all query and sort results by a numeric/timestamp
field, then we can replace the match-all with a filter over the
top/bottom 10,000 (or whatever `track_total_hits` is set to) values
from the sort field.

Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh
Copy link
Copy Markdown
Contributor Author

msfroh commented Oct 14, 2024

{"run-benchmark-test": "id_14"}

@github-actions
Copy link
Copy Markdown
Contributor

Invalid comment format or config id. Please refer to https://github.com/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests.

Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh msfroh force-pushed the approximate_MatchAllQuery_benchmark branch from 04a898c to 2ba6819 Compare October 14, 2024 22:11
@msfroh
Copy link
Copy Markdown
Contributor Author

msfroh commented Oct 14, 2024

{"run-benchmark-test": "id_14"}

@github-actions
Copy link
Copy Markdown
Contributor

Invalid comment format or config id. Please refer to https://github.com/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests.

@msfroh msfroh closed this Oct 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2ba6819:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant